* [PATCH] PCI: keystone: Remove unnecessary OOM message
@ 2014-11-12 3:22 Jingoo Han
2014-11-13 17:47 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-11-12 3:22 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Jingoo Han', 'Murali Karicheri',
'Santosh Shilimkar'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. This patch
fixes the following checkpatch warning.
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-keystone.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
index 1b893bc..62b9454 100644
--- a/drivers/pci/host/pci-keystone.c
+++ b/drivers/pci/host/pci-keystone.c
@@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie),
GFP_KERNEL);
- if (!ks_pcie) {
- dev_err(dev, "no memory for keystone pcie\n");
+ if (!ks_pcie)
return -ENOMEM;
- }
+
pp = &ks_pcie->pp;
/* initialize SerDes Phy if present */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: keystone: Remove unnecessary OOM message
2014-11-12 3:22 [PATCH] PCI: keystone: Remove unnecessary OOM message Jingoo Han
@ 2014-11-13 17:47 ` Bjorn Helgaas
2014-11-13 23:18 ` Murali Karicheri
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2014-11-13 17:47 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-pci, 'Murali Karicheri',
'Santosh Shilimkar'
On Wed, Nov 12, 2014 at 12:22:56PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. This patch
> fixes the following checkpatch warning.
>
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-keystone for v3.19, thanks!
Murali, let me know if you object. I'm trying to clear the easy stuff out
of my queue.
> ---
> drivers/pci/host/pci-keystone.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 1b893bc..62b9454 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
>
> ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie),
> GFP_KERNEL);
> - if (!ks_pcie) {
> - dev_err(dev, "no memory for keystone pcie\n");
> + if (!ks_pcie)
> return -ENOMEM;
> - }
> +
> pp = &ks_pcie->pp;
>
> /* initialize SerDes Phy if present */
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: keystone: Remove unnecessary OOM message
2014-11-13 17:47 ` Bjorn Helgaas
@ 2014-11-13 23:18 ` Murali Karicheri
0 siblings, 0 replies; 3+ messages in thread
From: Murali Karicheri @ 2014-11-13 23:18 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Jingoo Han, linux-pci, 'Santosh Shilimkar'
On 11/13/2014 12:47 PM, Bjorn Helgaas wrote:
> On Wed, Nov 12, 2014 at 12:22:56PM +0900, Jingoo Han wrote:
>> The site-specific OOM messages are unnecessary, because they
>> duplicate the MM subsystem generic OOM message. This patch
>> fixes the following checkpatch warning.
>>
>> WARNING: Possible unnecessary 'out of memory' message
>>
>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> Applied to pci/host-keystone for v3.19, thanks!
>
> Murali, let me know if you object. I'm trying to clear the easy stuff out
> of my queue.
I think this checkpatch warning is due to recent update to checkpatch.pl
script. Looks good to apply. Thanks
Murali
>> ---
>> drivers/pci/host/pci-keystone.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
>> index 1b893bc..62b9454 100644
>> --- a/drivers/pci/host/pci-keystone.c
>> +++ b/drivers/pci/host/pci-keystone.c
>> @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
>>
>> ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie),
>> GFP_KERNEL);
>> - if (!ks_pcie) {
>> - dev_err(dev, "no memory for keystone pcie\n");
>> + if (!ks_pcie)
>> return -ENOMEM;
>> - }
>> +
>> pp =&ks_pcie->pp;
>>
>> /* initialize SerDes Phy if present */
>> --
>> 1.7.9.5
>>
>>
--
Murali Karicheri
Linux Kernel, Texas Instruments
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-13 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 3:22 [PATCH] PCI: keystone: Remove unnecessary OOM message Jingoo Han
2014-11-13 17:47 ` Bjorn Helgaas
2014-11-13 23:18 ` Murali Karicheri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).