From: Bjorn Helgaas <bhelgaas@google.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: exynos: Remove unnecessary return statement
Date: Thu, 13 Nov 2014 10:51:36 -0700 [thread overview]
Message-ID: <20141113175136.GN5064@google.com> (raw)
In-Reply-To: <002901cffe28$544504b0$fccf0e10$%han@samsung.com>
On Wed, Nov 12, 2014 at 12:25:38PM +0900, Jingoo Han wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-exynos for v3.19, thanks!
> ---
> drivers/pci/host/pci-exynos.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index c5d0ca3..41ab139 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
> if (exynos_pcie->reset_gpio >= 0)
> devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
> GPIOF_OUT_INIT_HIGH, "RESET");
> - return;
> }
>
> static int exynos_pcie_establish_link(struct pcie_port *pp)
> @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
>
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
> - return;
> }
>
> static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> - return;
> }
>
> static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
> @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
> val |= IRQ_MSI_ENABLE;
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
> - return;
> }
>
> static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
> @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
>
> if (IS_ENABLED(CONFIG_PCI_MSI))
> exynos_pcie_msi_init(pp);
> -
> - return;
> }
>
> static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_r_mode(pp, true);
> *val = readl(dbi_base);
> exynos_pcie_sideband_dbi_r_mode(pp, false);
> - return;
> }
>
> static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_w_mode(pp, true);
> writel(val, dbi_base);
> exynos_pcie_sideband_dbi_w_mode(pp, false);
> - return;
> }
>
> static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
> --
> 1.7.9.5
>
>
prev parent reply other threads:[~2014-11-13 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 3:25 [PATCH] PCI: exynos: Remove unnecessary return statement Jingoo Han
2014-11-12 16:29 ` Srikanth Thokala
2014-11-13 2:09 ` Jingoo Han
2014-11-13 3:49 ` Srikanth Thokala
2014-11-13 17:51 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113175136.GN5064@google.com \
--to=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).