* [PATCH] PCI: exynos: Remove unnecessary return statement
@ 2014-11-12 3:25 Jingoo Han
2014-11-12 16:29 ` Srikanth Thokala
2014-11-13 17:51 ` Bjorn Helgaas
0 siblings, 2 replies; 5+ messages in thread
From: Jingoo Han @ 2014-11-12 3:25 UTC (permalink / raw)
To: 'Bjorn Helgaas'; +Cc: linux-pci, 'Jingoo Han'
This patch fixes the following checkpatch warning.
WARNING: void function return statements are not generally useful
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-exynos.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
index c5d0ca3..41ab139 100644
--- a/drivers/pci/host/pci-exynos.c
+++ b/drivers/pci/host/pci-exynos.c
@@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
if (exynos_pcie->reset_gpio >= 0)
devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
GPIOF_OUT_INIT_HIGH, "RESET");
- return;
}
static int exynos_pcie_establish_link(struct pcie_port *pp)
@@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
- return;
}
static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
@@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
- return;
}
static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
@@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
val |= IRQ_MSI_ENABLE;
exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
- return;
}
static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
@@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
if (IS_ENABLED(CONFIG_PCI_MSI))
exynos_pcie_msi_init(pp);
-
- return;
}
static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
@@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
exynos_pcie_sideband_dbi_r_mode(pp, true);
*val = readl(dbi_base);
exynos_pcie_sideband_dbi_r_mode(pp, false);
- return;
}
static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
@@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
exynos_pcie_sideband_dbi_w_mode(pp, true);
writel(val, dbi_base);
exynos_pcie_sideband_dbi_w_mode(pp, false);
- return;
}
static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: exynos: Remove unnecessary return statement
2014-11-12 3:25 [PATCH] PCI: exynos: Remove unnecessary return statement Jingoo Han
@ 2014-11-12 16:29 ` Srikanth Thokala
2014-11-13 2:09 ` Jingoo Han
2014-11-13 17:51 ` Bjorn Helgaas
1 sibling, 1 reply; 5+ messages in thread
From: Srikanth Thokala @ 2014-11-12 16:29 UTC (permalink / raw)
To: Jingoo Han; +Cc: Bjorn Helgaas, linux-pci@vger.kernel.org
On Wed, Nov 12, 2014 at 8:55 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-exynos.c | 8 --------
> 1 file changed, 8 deletions(-)
>
Acked-by: Srikanth Thokala <sriku.linux@gmail.com>
- Srikanth
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index c5d0ca3..41ab139 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
> if (exynos_pcie->reset_gpio >= 0)
> devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
> GPIOF_OUT_INIT_HIGH, "RESET");
> - return;
> }
>
> static int exynos_pcie_establish_link(struct pcie_port *pp)
> @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
>
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
> - return;
> }
>
> static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> - return;
> }
>
> static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
> @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
> val |= IRQ_MSI_ENABLE;
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
> - return;
> }
>
> static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
> @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
>
> if (IS_ENABLED(CONFIG_PCI_MSI))
> exynos_pcie_msi_init(pp);
> -
> - return;
> }
>
> static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_r_mode(pp, true);
> *val = readl(dbi_base);
> exynos_pcie_sideband_dbi_r_mode(pp, false);
> - return;
> }
>
> static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_w_mode(pp, true);
> writel(val, dbi_base);
> exynos_pcie_sideband_dbi_w_mode(pp, false);
> - return;
> }
>
> static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
> --
> 1.7.9.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: exynos: Remove unnecessary return statement
2014-11-12 16:29 ` Srikanth Thokala
@ 2014-11-13 2:09 ` Jingoo Han
2014-11-13 3:49 ` Srikanth Thokala
0 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2014-11-13 2:09 UTC (permalink / raw)
To: 'Srikanth Thokala'
Cc: 'Bjorn Helgaas', linux-pci, 'Jingoo Han'
On Thursday, November 13, 2014 1:30 AM, Srikanth Thokala wrote:
>
> On Wed, Nov 12, 2014 at 8:55 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> > This patch fixes the following checkpatch warning.
> >
> > WARNING: void function return statements are not generally useful
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/pci/host/pci-exynos.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
>
> Acked-by: Srikanth Thokala <sriku.linux@gmail.com>
Sorry, but your 'Acked-by' is NOT appropriate.
You are neither a maintainer nor those who contributed the patch
for Exynos PCIe driver. So, in this case, 'Reviewed-by' looks good
as below.
Reviewed-by: Srikanth Thokala <sriku.linux@gmail.com>
By the way, you submitted the Xilinx PCIe driver
(drivers/pci/host/pcie-xilinx.c). Thus, if someone send
the patch for Xilinx PCIe driver, you can give your Acked-by.
According to the 'Documentation/SubmittingPatches' file,
"If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.
Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch."
My comment will be also applied to the patch "[PATCH] PCI: imx6: Use tabs
for indentation".
Thank you.
Best regards,
Jingoo Han
>
> - Srikanth
>
> > diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> > index c5d0ca3..41ab139 100644
> > --- a/drivers/pci/host/pci-exynos.c
> > +++ b/drivers/pci/host/pci-exynos.c
> > @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
> > if (exynos_pcie->reset_gpio >= 0)
> > devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
> > GPIOF_OUT_INIT_HIGH, "RESET");
> > - return;
> > }
> >
> > static int exynos_pcie_establish_link(struct pcie_port *pp)
> > @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
> >
> > val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
> > - return;
> > }
> >
> > static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> > @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> > val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> > IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> > - return;
> > }
> >
> > static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
> > @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
> > val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
> > val |= IRQ_MSI_ENABLE;
> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
> > - return;
> > }
> >
> > static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
> > @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
> >
> > if (IS_ENABLED(CONFIG_PCI_MSI))
> > exynos_pcie_msi_init(pp);
> > -
> > - return;
> > }
> >
> > static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> > @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> > exynos_pcie_sideband_dbi_r_mode(pp, true);
> > *val = readl(dbi_base);
> > exynos_pcie_sideband_dbi_r_mode(pp, false);
> > - return;
> > }
> >
> > static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> > @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> > exynos_pcie_sideband_dbi_w_mode(pp, true);
> > writel(val, dbi_base);
> > exynos_pcie_sideband_dbi_w_mode(pp, false);
> > - return;
> > }
> >
> > static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
> > --
> > 1.7.9.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: exynos: Remove unnecessary return statement
2014-11-13 2:09 ` Jingoo Han
@ 2014-11-13 3:49 ` Srikanth Thokala
0 siblings, 0 replies; 5+ messages in thread
From: Srikanth Thokala @ 2014-11-13 3:49 UTC (permalink / raw)
To: Jingoo Han; +Cc: Bjorn Helgaas, linux-pci@vger.kernel.org
On Thu, Nov 13, 2014 at 7:39 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, November 13, 2014 1:30 AM, Srikanth Thokala wrote:
>>
>> On Wed, Nov 12, 2014 at 8:55 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>> > This patch fixes the following checkpatch warning.
>> >
>> > WARNING: void function return statements are not generally useful
>> >
>> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>> > ---
>> > drivers/pci/host/pci-exynos.c | 8 --------
>> > 1 file changed, 8 deletions(-)
>> >
>>
>> Acked-by: Srikanth Thokala <sriku.linux@gmail.com>
>
> Sorry, but your 'Acked-by' is NOT appropriate.
> You are neither a maintainer nor those who contributed the patch
> for Exynos PCIe driver. So, in this case, 'Reviewed-by' looks good
> as below.
>
> Reviewed-by: Srikanth Thokala <sriku.linux@gmail.com>
>
> By the way, you submitted the Xilinx PCIe driver
> (drivers/pci/host/pcie-xilinx.c). Thus, if someone send
> the patch for Xilinx PCIe driver, you can give your Acked-by.
>
> According to the 'Documentation/SubmittingPatches' file,
>
> "If a person was not directly involved in the preparation or handling of a
> patch but wishes to signify and record their approval of it then they can
> arrange to have an Acked-by: line added to the patch's changelog.
>
> Acked-by: is often used by the maintainer of the affected code when that
> maintainer neither contributed to nor forwarded the patch."
>
> My comment will be also applied to the patch "[PATCH] PCI: imx6: Use tabs
> for indentation".
Thank you for the information, I will keep that in mind.
- Srikanth
>
> Thank you.
>
> Best regards,
> Jingoo Han
>
>>
>> - Srikanth
>>
>> > diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
>> > index c5d0ca3..41ab139 100644
>> > --- a/drivers/pci/host/pci-exynos.c
>> > +++ b/drivers/pci/host/pci-exynos.c
>> > @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
>> > if (exynos_pcie->reset_gpio >= 0)
>> > devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
>> > GPIOF_OUT_INIT_HIGH, "RESET");
>> > - return;
>> > }
>> >
>> > static int exynos_pcie_establish_link(struct pcie_port *pp)
>> > @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
>> >
>> > val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
>> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
>> > - return;
>> > }
>> >
>> > static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
>> > @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
>> > val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
>> > IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
>> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
>> > - return;
>> > }
>> >
>> > static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
>> > @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
>> > val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
>> > val |= IRQ_MSI_ENABLE;
>> > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
>> > - return;
>> > }
>> >
>> > static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
>> > @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
>> >
>> > if (IS_ENABLED(CONFIG_PCI_MSI))
>> > exynos_pcie_msi_init(pp);
>> > -
>> > - return;
>> > }
>> >
>> > static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
>> > @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
>> > exynos_pcie_sideband_dbi_r_mode(pp, true);
>> > *val = readl(dbi_base);
>> > exynos_pcie_sideband_dbi_r_mode(pp, false);
>> > - return;
>> > }
>> >
>> > static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
>> > @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
>> > exynos_pcie_sideband_dbi_w_mode(pp, true);
>> > writel(val, dbi_base);
>> > exynos_pcie_sideband_dbi_w_mode(pp, false);
>> > - return;
>> > }
>> >
>> > static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
>> > --
>> > 1.7.9.5
>> >
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: exynos: Remove unnecessary return statement
2014-11-12 3:25 [PATCH] PCI: exynos: Remove unnecessary return statement Jingoo Han
2014-11-12 16:29 ` Srikanth Thokala
@ 2014-11-13 17:51 ` Bjorn Helgaas
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2014-11-13 17:51 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-pci
On Wed, Nov 12, 2014 at 12:25:38PM +0900, Jingoo Han wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied to pci/host-exynos for v3.19, thanks!
> ---
> drivers/pci/host/pci-exynos.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
> index c5d0ca3..41ab139 100644
> --- a/drivers/pci/host/pci-exynos.c
> +++ b/drivers/pci/host/pci-exynos.c
> @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp)
> if (exynos_pcie->reset_gpio >= 0)
> devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio,
> GPIOF_OUT_INIT_HIGH, "RESET");
> - return;
> }
>
> static int exynos_pcie_establish_link(struct pcie_port *pp)
> @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp)
>
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE);
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE);
> - return;
> }
>
> static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp)
> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT |
> IRQ_INTC_ASSERT | IRQ_INTD_ASSERT,
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE);
> - return;
> }
>
> static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg)
> @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp)
> val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL);
> val |= IRQ_MSI_ENABLE;
> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL);
> - return;
> }
>
> static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
> @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp)
>
> if (IS_ENABLED(CONFIG_PCI_MSI))
> exynos_pcie_msi_init(pp);
> -
> - return;
> }
>
> static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_r_mode(pp, true);
> *val = readl(dbi_base);
> exynos_pcie_sideband_dbi_r_mode(pp, false);
> - return;
> }
>
> static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp,
> exynos_pcie_sideband_dbi_w_mode(pp, true);
> writel(val, dbi_base);
> exynos_pcie_sideband_dbi_w_mode(pp, false);
> - return;
> }
>
> static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-13 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 3:25 [PATCH] PCI: exynos: Remove unnecessary return statement Jingoo Han
2014-11-12 16:29 ` Srikanth Thokala
2014-11-13 2:09 ` Jingoo Han
2014-11-13 3:49 ` Srikanth Thokala
2014-11-13 17:51 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).