* [PATCH] PCI: mvebu: Add a blank line after declarations
@ 2014-11-12 3:27 Jingoo Han
2014-11-12 13:32 ` Jason Cooper
2014-11-13 17:55 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2014-11-12 3:27 UTC (permalink / raw)
To: 'Bjorn Helgaas'
Cc: linux-pci, 'Jingoo Han', 'Thomas Petazzoni',
'Jason Cooper'
This patch fixes the following checkpatch warning.
WARNING: Missing a blank line after declarations
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pci/host/pci-mvebu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index b1315e1..0c775afa 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -622,6 +622,7 @@ static struct mvebu_pcie_port *mvebu_pcie_find_port(struct mvebu_pcie *pcie,
for (i = 0; i < pcie->nports; i++) {
struct mvebu_pcie_port *port = &pcie->ports[i];
+
if (bus->number == 0 && port->devfn == devfn)
return port;
if (bus->number != 0 &&
@@ -751,6 +752,7 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
for (i = 0; i < pcie->nports; i++) {
struct mvebu_pcie_port *port = &pcie->ports[i];
+
if (!port->base)
continue;
mvebu_pcie_setup_hw(port);
@@ -777,6 +779,7 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
static void mvebu_pcie_add_bus(struct pci_bus *bus)
{
struct mvebu_pcie *pcie = sys_to_pcie(bus->sysdata);
+
bus->msi = pcie->msi;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: mvebu: Add a blank line after declarations
2014-11-12 3:27 [PATCH] PCI: mvebu: Add a blank line after declarations Jingoo Han
@ 2014-11-12 13:32 ` Jason Cooper
2014-11-13 17:55 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2014-11-12 13:32 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Bjorn Helgaas', linux-pci, 'Thomas Petazzoni'
On Wed, Nov 12, 2014 at 12:27:54PM +0900, Jingoo Han wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-mvebu.c | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: mvebu: Add a blank line after declarations
2014-11-12 3:27 [PATCH] PCI: mvebu: Add a blank line after declarations Jingoo Han
2014-11-12 13:32 ` Jason Cooper
@ 2014-11-13 17:55 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-11-13 17:55 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-pci, 'Thomas Petazzoni', 'Jason Cooper'
On Wed, Nov 12, 2014 at 12:27:54PM +0900, Jingoo Han wrote:
> This patch fixes the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied with Jason's ack to pci/host-mvebu for v3.19, thanks!
I dropped the mvebu_pcie_add_bus() hunk because I have a patch in pci/msi
that removes that function altogether.
> ---
> drivers/pci/host/pci-mvebu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index b1315e1..0c775afa 100644
> --- a/drivers/pci/host/pci-mvebu.c
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -622,6 +622,7 @@ static struct mvebu_pcie_port *mvebu_pcie_find_port(struct mvebu_pcie *pcie,
>
> for (i = 0; i < pcie->nports; i++) {
> struct mvebu_pcie_port *port = &pcie->ports[i];
> +
> if (bus->number == 0 && port->devfn == devfn)
> return port;
> if (bus->number != 0 &&
> @@ -751,6 +752,7 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
>
> for (i = 0; i < pcie->nports; i++) {
> struct mvebu_pcie_port *port = &pcie->ports[i];
> +
> if (!port->base)
> continue;
> mvebu_pcie_setup_hw(port);
> @@ -777,6 +779,7 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
> static void mvebu_pcie_add_bus(struct pci_bus *bus)
> {
> struct mvebu_pcie *pcie = sys_to_pcie(bus->sysdata);
> +
> bus->msi = pcie->msi;
> }
>
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-13 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 3:27 [PATCH] PCI: mvebu: Add a blank line after declarations Jingoo Han
2014-11-12 13:32 ` Jason Cooper
2014-11-13 17:55 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).