* [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
@ 2014-11-14 22:19 Dmitry Torokhov
2014-11-19 18:02 ` Murali Karicheri
2014-12-09 22:38 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-11-14 22:19 UTC (permalink / raw)
To: Murali Karicheri
Cc: Bjorn Helgaas, Santosh Shilimkar, Arnd Bergmann, Wolfram Sang,
linux-pci, linux-arm-kernel, linux-kernel
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
Not tested, found by casual code inspection.
drivers/pci/host/pci-keystone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
index 8a27078..f2bd48d 100644
--- a/drivers/pci/host/pci-keystone.c
+++ b/drivers/pci/host/pci-keystone.c
@@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
*/
for (temp = 0; temp < max_host_irqs; temp++) {
host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
- if (host_irqs[temp] < 0)
+ if (!host_irqs[temp])
break;
}
if (temp) {
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
2014-11-14 22:19 [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Dmitry Torokhov
@ 2014-11-19 18:02 ` Murali Karicheri
2014-12-09 22:38 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Murali Karicheri @ 2014-11-19 18:02 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Bjorn Helgaas, Arnd Bergmann, Wolfram Sang, linux-pci,
linux-arm-kernel, linux-kernel
On 11/14/2014 05:19 PM, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov<dtor@chromium.org>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
> */
> for (temp = 0; temp< max_host_irqs; temp++) {
> host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> - if (host_irqs[temp]< 0)
> + if (!host_irqs[temp])
> break;
> }
> if (temp) {
Good catch!
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
--
Murali Karicheri
Linux Kernel, Texas Instruments
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
2014-11-14 22:19 [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-19 18:02 ` Murali Karicheri
@ 2014-12-09 22:38 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-12-09 22:38 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Murali Karicheri, Santosh Shilimkar, Arnd Bergmann, Wolfram Sang,
linux-pci, linux-arm-kernel, linux-kernel
On Fri, Nov 14, 2014 at 02:19:03PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Applied with Murali's ack to next-pci/host-keystone for v3.19. This
branch will be rebased to v3.19-rc1.
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
> */
> for (temp = 0; temp < max_host_irqs; temp++) {
> host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> - if (host_irqs[temp] < 0)
> + if (!host_irqs[temp])
> break;
> }
> if (temp) {
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 22:19 [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-19 18:02 ` Murali Karicheri
2014-12-09 22:38 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).