From: Bjorn Helgaas <bhelgaas@google.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Murali Karicheri <m-karicheri2@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Arnd Bergmann <arnd@arndb.de>, Wolfram Sang <wsa@the-dreams.de>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map
Date: Tue, 9 Dec 2014 15:38:09 -0700 [thread overview]
Message-ID: <20141209223809.GB6692@google.com> (raw)
In-Reply-To: <20141114221903.GA38539@dtor-ws>
On Fri, Nov 14, 2014 at 02:19:03PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Applied with Murali's ack to next-pci/host-keystone for v3.19. This
branch will be rebased to v3.19-rc1.
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pci-keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
> index 8a27078..f2bd48d 100644
> --- a/drivers/pci/host/pci-keystone.c
> +++ b/drivers/pci/host/pci-keystone.c
> @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
> */
> for (temp = 0; temp < max_host_irqs; temp++) {
> host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
> - if (host_irqs[temp] < 0)
> + if (!host_irqs[temp])
> break;
> }
> if (temp) {
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
prev parent reply other threads:[~2014-12-09 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:19 [PATCH] PCI: keystone: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-19 18:02 ` Murali Karicheri
2014-12-09 22:38 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209223809.GB6692@google.com \
--to=bhelgaas@google.com \
--cc=arnd@arndb.de \
--cc=dtor@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).