From: Bjorn Helgaas <bhelgaas@google.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Simon Horman <horms@verge.net.au>,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-pci@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map
Date: Tue, 9 Dec 2014 15:38:46 -0700 [thread overview]
Message-ID: <20141209223846.GC6692@google.com> (raw)
In-Reply-To: <20141114222153.GA39494@dtor-ws>
On Fri, Nov 14, 2014 at 02:21:53PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Applied with Phil's ack to next-pci/host-rcar for v3.19. This branch will
be rebased to v3.19-rc1.
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pcie-rcar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 9b356c3..6ca976f 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -764,7 +764,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
> goto err_map_reg;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> @@ -772,7 +772,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
> pcie->msi.irq1 = i;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 1);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
prev parent reply other threads:[~2014-12-09 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:21 [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-18 10:43 ` Phil Edworthy
2014-12-09 22:38 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209223846.GC6692@google.com \
--to=bhelgaas@google.com \
--cc=dtor@chromium.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).