* [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map
@ 2014-11-14 22:21 Dmitry Torokhov
2014-11-18 10:43 ` Phil Edworthy
2014-12-09 22:38 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-11-14 22:21 UTC (permalink / raw)
To: Simon Horman
Cc: Bjorn Helgaas, Phil Edworthy, linux-pci, linux-sh, linux-kernel
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
Not tested, found by casual code inspection.
drivers/pci/host/pcie-rcar.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 9b356c3..6ca976f 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -764,7 +764,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
goto err_map_reg;
i = irq_of_parse_and_map(pdev->dev.of_node, 0);
- if (i < 0) {
+ if (!i) {
dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
err = -ENOENT;
goto err_map_reg;
@@ -772,7 +772,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
pcie->msi.irq1 = i;
i = irq_of_parse_and_map(pdev->dev.of_node, 1);
- if (i < 0) {
+ if (!i) {
dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
err = -ENOENT;
goto err_map_reg;
--
2.1.0.rc2.206.gedb03e5
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map
2014-11-14 22:21 [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map Dmitry Torokhov
@ 2014-11-18 10:43 ` Phil Edworthy
2014-12-09 22:38 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Phil Edworthy @ 2014-11-18 10:43 UTC (permalink / raw)
To: Dmitry Torokhov, Simon Horman
Cc: Bjorn Helgaas, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Dmitry,
On 14 November 2014 22:22, Dmitry wrote:
>
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
Thanks
Phil
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pcie-rcar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 9b356c3..6ca976f 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -764,7 +764,7 @@ static int rcar_pcie_get_resources(struct platform_device
> *pdev,
> goto err_map_reg;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi
> interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> @@ -772,7 +772,7 @@ static int rcar_pcie_get_resources(struct platform_device
> *pdev,
> pcie->msi.irq1 = i;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 1);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi
> interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map
2014-11-14 22:21 [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-18 10:43 ` Phil Edworthy
@ 2014-12-09 22:38 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2014-12-09 22:38 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Simon Horman, Phil Edworthy, linux-pci, linux-sh, linux-kernel
On Fri, Nov 14, 2014 at 02:21:53PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Applied with Phil's ack to next-pci/host-rcar for v3.19. This branch will
be rebased to v3.19-rc1.
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/pci/host/pcie-rcar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 9b356c3..6ca976f 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -764,7 +764,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
> goto err_map_reg;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 0);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> @@ -772,7 +772,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev,
> pcie->msi.irq1 = i;
>
> i = irq_of_parse_and_map(pdev->dev.of_node, 1);
> - if (i < 0) {
> + if (!i) {
> dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");
> err = -ENOENT;
> goto err_map_reg;
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 22:21 [PATCH] PCI: rcar: fix error handling of irq_of_parse_and_map Dmitry Torokhov
2014-11-18 10:43 ` Phil Edworthy
2014-12-09 22:38 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).