From: Bjorn Helgaas <bhelgaas@google.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: tegra: remove bogus bridge setup fixup
Date: Wed, 10 Dec 2014 14:14:54 -0700 [thread overview]
Message-ID: <20141210211454.GE6692@google.com> (raw)
In-Reply-To: <1415907457-3147-3-git-send-email-l.stach@pengutronix.de>
On Thu, Nov 13, 2014 at 08:37:37PM +0100, Lucas Stach wrote:
> The bridge setup is already done by generic code
> while scanning the buses. Do not duplicate (or potentially
> alter) this setup as a fixup.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied to next-pci/host-tegra for v3.19, with Tested-by, Reviewed-by, and
Acked-by from Alexandre and Thierry. This branch will be rebased to
v3.19-rc1 when it comes out.
Bjorn
> ---
> drivers/pci/host/pci-tegra.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index d5a14f22ebb8..0ef22505cead 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -624,19 +624,6 @@ static void tegra_pcie_port_free(struct tegra_pcie_port *port)
> devm_kfree(pcie->dev, port);
> }
>
> -static void tegra_pcie_fixup_bridge(struct pci_dev *dev)
> -{
> - u16 reg;
> -
> - if ((dev->class >> 16) == PCI_BASE_CLASS_BRIDGE) {
> - pci_read_config_word(dev, PCI_COMMAND, ®);
> - reg |= (PCI_COMMAND_IO | PCI_COMMAND_MEMORY |
> - PCI_COMMAND_MASTER | PCI_COMMAND_SERR);
> - pci_write_config_word(dev, PCI_COMMAND, reg);
> - }
> -}
> -DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, tegra_pcie_fixup_bridge);
> -
> /* Tegra PCIE root complex wrongly reports device class */
> static void tegra_pcie_fixup_class(struct pci_dev *dev)
> {
> --
> 2.1.1
>
next prev parent reply other threads:[~2014-12-10 21:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 19:37 [PATCH 0/2] Tegra PCI multiplatform fixes Lucas Stach
2014-11-13 19:37 ` [PATCH 1/2] PCI: tegra: apply relaxed ordering fixup only on Tegra Lucas Stach
2014-12-09 3:23 ` Alexandre Courbot
2014-12-09 10:28 ` Lucas Stach
2014-12-10 12:13 ` Thierry Reding
2014-12-10 12:23 ` Lucas Stach
2014-12-10 14:11 ` Thierry Reding
2014-12-10 14:15 ` Lucas Stach
2014-12-10 14:31 ` Thierry Reding
2014-12-09 22:31 ` Bjorn Helgaas
2014-11-13 19:37 ` [PATCH 2/2] PCI: tegra: remove bogus bridge setup fixup Lucas Stach
2014-12-09 3:17 ` Alexandre Courbot
2014-12-10 12:16 ` Thierry Reding
2014-12-10 21:14 ` Bjorn Helgaas [this message]
2014-12-05 19:06 ` [PATCH 0/2] Tegra PCI multiplatform fixes Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210211454.GE6692@google.com \
--to=bhelgaas@google.com \
--cc=gnurou@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).