From: Bjorn Helgaas <bhelgaas@google.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Chuansheng Liu <chuansheng.liu@intel.com>,
rjw@rjwysocki.net, mister.freeman@laposte.net,
aaron.lu@intel.com, tj@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] PCI: Add disabling pm async quirk for JMicron chips
Date: Fri, 9 Jan 2015 10:46:52 -0700 [thread overview]
Message-ID: <20150109174652.GE6575@google.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1412051415180.13167-100000@ida.rowland.org>
On Fri, Dec 05, 2014 at 02:18:40PM -0500, Alan Stern wrote:
> On Fri, 5 Dec 2014, Chuansheng Liu wrote:
>
> > Some history from
> > commit e6b7e41cdd8c ("ata: Disabling the async PM for JMicron chip 363/361")
> > ==
> > Since v3.15, the PM feature of async noirq
> > commit 76569faa62c4 ("PM / sleep: Asynchronous threads for resume_noirq") is introduced.
> >
> > Then Jay hit one system resuming issue that one of the JMicron controller
> > can not be powered up successfully.
> >
> > His device tree is like below:
> > +-1c.4-[02]--+-00.0 JMicron Technology Corp. JMB363 SATA/IDE Controller
> > | \-00.1 JMicron Technology Corp. JMB363 SATA/IDE Controller
> >
> > After investigation, we found the the Micron chip 363 included
> > one SATA controller(0000:02:00.0) and one PATA controller(0000:02:00.1),
> > these two controllers do not have parent-children relationship,
> > but the PATA controller only can be powered on after the SATA controller
> > has finished the powering on.
> >
> > If we enabled the async noirq(), then the below error is hit during noirq
> > phase:
> > pata_jmicron 0000:02:00.1: Refused to change power state, currently in D3
> > Here for JMicron chip 363/361, we need forcedly to disable the async method.
>
> You know, this is exactly why device_pm_wait_for_dev() exists -- so
> that asynchronous power-management operations can wait for other
> devices even when there's no parent-child relation.
>
> You should try to use device_pm_wait_for_dev() instead of disabling
> async suspend/resume.
Dropping this patch for now, waiting for a response to Alan's suggestion.
Bjorn
next prev parent reply other threads:[~2015-01-09 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 7:17 [PATCH] PCI: Add disabling pm async quirk for JMicron chips Chuansheng Liu
2014-12-05 14:45 ` Tejun Heo
2014-12-05 16:41 ` Barto
2014-12-05 19:18 ` Alan Stern
2015-01-09 17:46 ` Bjorn Helgaas [this message]
2015-05-11 6:58 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109174652.GE6575@google.com \
--to=bhelgaas@google.com \
--cc=aaron.lu@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mister.freeman@laposte.net \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).