From: Bjorn Helgaas <bhelgaas@google.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH v2 04/10] PCI, frv: clip firmware assigned resource under parent bridge's
Date: Thu, 15 Jan 2015 10:19:31 -0600 [thread overview]
Message-ID: <20150115161931.GA7105@google.com> (raw)
In-Reply-To: <CAE9FiQXi05_uH-fmPVPJNdm93DHbb26h6vDvsNuQb-KGAT7ung@mail.gmail.com>
On Wed, Jan 14, 2015 at 08:51:22PM -0800, Yinghai Lu wrote:
> On Wed, Jan 14, 2015 at 8:31 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> > Some bios put range that is not fully coverred by root bus resources.
> > Try to clip them and update them in pci bridge bars.
> >
> > We'd like to fix other arches instead of just x86.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=85491
> > Reported-by: Marek Kordik <kordikmarek@gmail.com>
> > Fixes: 5b28541552ef ("PCI: Restrict 64-bit prefetchable bridge windows to 64-bit resources")
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> > arch/frv/mb93090-mb00/pci-frv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/frv/mb93090-mb00/pci-frv.c b/arch/frv/mb93090-mb00/pci-frv.c
> > index 67b1d16..9e49c3e 100644
> > --- a/arch/frv/mb93090-mb00/pci-frv.c
> > +++ b/arch/frv/mb93090-mb00/pci-frv.c
> > @@ -94,7 +94,7 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list)
> > r = &dev->resource[idx];
> > if (!r->start)
> > continue;
> > - pci_claim_resource(dev, idx);
> > + pci_claim_bridge_resource(dev, idx)
>
> miss ; here.
>
> Please let me know if you can fix it manually.
Fixed, thanks.
next prev parent reply other threads:[~2015-01-15 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 4:31 [PATCH v2 00/10] PCI: clip firmware assigned resources Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 01/10] PCI: clip firmware assigned resource under parent bridge's Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 02/10] PCI, x86: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 03/10] PCI, alpha: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 04/10] PCI, frv: " Yinghai Lu
2015-01-15 4:51 ` Yinghai Lu
2015-01-15 16:19 ` Bjorn Helgaas [this message]
2015-01-15 4:31 ` [PATCH v2 05/10] PCI, ia64: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 06/10] PCI, microblaze: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 07/10] PCI, mn10300: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 08/10] PCI, parisc: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 09/10] PCI, powerpc: " Yinghai Lu
2015-01-15 4:31 ` [PATCH v2 10/10] PCI, sparc: " Yinghai Lu
2015-01-16 0:14 ` David Miller
2015-01-15 22:24 ` [PATCH v2 00/10] PCI: clip firmware assigned resources Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115161931.GA7105@google.com \
--to=bhelgaas@google.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).