* Re: [PATCH V2] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c [not found] <1424132571-32018-1-git-send-email-xerofoify@gmail.com> @ 2015-02-18 17:11 ` Ingo Molnar 2015-02-18 18:06 ` Ingo Molnar 0 siblings, 1 reply; 2+ messages in thread From: Ingo Molnar @ 2015-02-18 17:11 UTC (permalink / raw) To: Nicholas Krause; +Cc: bhelgaas, tglx, mingo, hpa, x86, linux-pci, linux-kernel * Nicholas Krause <xerofoify@gmail.com> wrote: > This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported > as it's function for dma_supported hardware verus setting this value to NULL as > this should be set correctly for when dma_supported function needs to be called > for this hardware. Otherwise this will cause a bug that will crash a operation > needing to access this function if an intended hardware operation needs to call > it but the kernel has the function pointer for this structure set to NULL > incorrectly. Hm, I have asked a question for the v1 patch already: https://lkml.org/lkml/2015/2/16/30 is there an answer to my question? Thanks, Ingo ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V2] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c 2015-02-18 17:11 ` [PATCH V2] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c Ingo Molnar @ 2015-02-18 18:06 ` Ingo Molnar 0 siblings, 0 replies; 2+ messages in thread From: Ingo Molnar @ 2015-02-18 18:06 UTC (permalink / raw) To: Nicholas Krause; +Cc: bhelgaas, tglx, mingo, hpa, x86, linux-pci, linux-kernel * Ingo Molnar <mingo@kernel.org> wrote: > > * Nicholas Krause <xerofoify@gmail.com> wrote: > > > This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported > > as it's function for dma_supported hardware verus setting this value to NULL as > > this should be set correctly for when dma_supported function needs to be called > > for this hardware. Otherwise this will cause a bug that will crash a operation > > needing to access this function if an intended hardware operation needs to call > > it but the kernel has the function pointer for this structure set to NULL > > incorrectly. > > Hm, I have asked a question for the v1 patch already: > > https://lkml.org/lkml/2015/2/16/30 > > is there an answer to my question? Ok, found your reply meanwhile - somehow lkml didn't index the thread properly :-/ Thanks, Ingo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-18 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1424132571-32018-1-git-send-email-xerofoify@gmail.com>
2015-02-18 17:11 ` [PATCH V2] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c Ingo Molnar
2015-02-18 18:06 ` Ingo Molnar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).