From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:36450 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbbBRSGY (ORCPT ); Wed, 18 Feb 2015 13:06:24 -0500 Date: Wed, 18 Feb 2015 19:06:19 +0100 From: Ingo Molnar To: Nicholas Krause Cc: bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c Message-ID: <20150218180619.GA32158@gmail.com> References: <1424132571-32018-1-git-send-email-xerofoify@gmail.com> <20150218171151.GA29241@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150218171151.GA29241@gmail.com> Sender: linux-pci-owner@vger.kernel.org List-ID: * Ingo Molnar wrote: > > * Nicholas Krause wrote: > > > This changes the structure sta2x11_dma_ops stucture to use switolb_dma_supported > > as it's function for dma_supported hardware verus setting this value to NULL as > > this should be set correctly for when dma_supported function needs to be called > > for this hardware. Otherwise this will cause a bug that will crash a operation > > needing to access this function if an intended hardware operation needs to call > > it but the kernel has the function pointer for this structure set to NULL > > incorrectly. > > Hm, I have asked a question for the v1 patch already: > > https://lkml.org/lkml/2015/2/16/30 > > is there an answer to my question? Ok, found your reply meanwhile - somehow lkml didn't index the thread properly :-/ Thanks, Ingo