* [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL
@ 2015-02-02 5:09 Nobuhiro Iwamatsu
2015-02-03 18:53 ` Phil Edworthy
2015-02-24 6:25 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2015-02-02 5:09 UTC (permalink / raw)
To: bhelgaas; +Cc: linux-pci, phil.edworthy, horms+renesas, Nobuhiro Iwamatsu
Lower 7bit of PCIEPARL is reserved bit. When we write to this register,
these bits must be 0.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index 748786c..bb36e27 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -342,7 +342,8 @@ static void rcar_pcie_setup_window(int win, struct rcar_pcie *pcie)
res_start = res->start;
rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPARH(win));
- rcar_pci_write_reg(pcie, lower_32_bits(res_start), PCIEPARL(win));
+ rcar_pci_write_reg(pcie, lower_32_bits(res_start) & ~0x7F,
+ PCIEPARL(win));
/* First resource is for IO */
mask = PAR_ENABLE;
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL
2015-02-02 5:09 [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL Nobuhiro Iwamatsu
@ 2015-02-03 18:53 ` Phil Edworthy
2015-02-24 2:02 ` Simon Horman
2015-02-24 6:25 ` Bjorn Helgaas
1 sibling, 1 reply; 4+ messages in thread
From: Phil Edworthy @ 2015-02-03 18:53 UTC (permalink / raw)
To: Nobuhiro Iwamatsu
Cc: linux-pci@vger.kernel.org, horms+renesas@verge.net.au,
Nobuhiro Iwamatsu, bhelgaas@google.com
Hi Iwamatsu-san,
On: 02 February 2015 05:10, Nobuhiro Iwamatsu wrote:
>
> Lower 7bit of PCIEPARL is reserved bit. When we write to this register,
> these bits must be 0.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
Thanks
Phil
> ---
> drivers/pci/host/pcie-rcar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 748786c..bb36e27 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -342,7 +342,8 @@ static void rcar_pcie_setup_window(int win, struct
> rcar_pcie *pcie)
> res_start = res->start;
>
> rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPARH(win));
> - rcar_pci_write_reg(pcie, lower_32_bits(res_start), PCIEPARL(win));
> + rcar_pci_write_reg(pcie, lower_32_bits(res_start) & ~0x7F,
> + PCIEPARL(win));
>
> /* First resource is for IO */
> mask = PAR_ENABLE;
> --
> 2.1.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL
2015-02-03 18:53 ` Phil Edworthy
@ 2015-02-24 2:02 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2015-02-24 2:02 UTC (permalink / raw)
To: Phil Edworthy
Cc: Nobuhiro Iwamatsu, linux-pci@vger.kernel.org, bhelgaas@google.com
On Tue, Feb 03, 2015 at 06:53:51PM +0000, Phil Edworthy wrote:
> Hi Iwamatsu-san,
>
> On: 02 February 2015 05:10, Nobuhiro Iwamatsu wrote:
> >
> > Lower 7bit of PCIEPARL is reserved bit. When we write to this register,
> > these bits must be 0.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks
> Phil
>
> > ---
> > drivers/pci/host/pcie-rcar.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> > index 748786c..bb36e27 100644
> > --- a/drivers/pci/host/pcie-rcar.c
> > +++ b/drivers/pci/host/pcie-rcar.c
> > @@ -342,7 +342,8 @@ static void rcar_pcie_setup_window(int win, struct
> > rcar_pcie *pcie)
> > res_start = res->start;
> >
> > rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPARH(win));
> > - rcar_pci_write_reg(pcie, lower_32_bits(res_start), PCIEPARL(win));
> > + rcar_pci_write_reg(pcie, lower_32_bits(res_start) & ~0x7F,
> > + PCIEPARL(win));
> >
> > /* First resource is for IO */
> > mask = PAR_ENABLE;
> > --
> > 2.1.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL
2015-02-02 5:09 [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL Nobuhiro Iwamatsu
2015-02-03 18:53 ` Phil Edworthy
@ 2015-02-24 6:25 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2015-02-24 6:25 UTC (permalink / raw)
To: Nobuhiro Iwamatsu; +Cc: linux-pci, phil.edworthy, horms+renesas
On Mon, Feb 02, 2015 at 02:09:58PM +0900, Nobuhiro Iwamatsu wrote:
> Lower 7bit of PCIEPARL is reserved bit. When we write to this register,
> these bits must be 0.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied to pci/host-rcar for v4.1, thanks!
> ---
> drivers/pci/host/pcie-rcar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index 748786c..bb36e27 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -342,7 +342,8 @@ static void rcar_pcie_setup_window(int win, struct rcar_pcie *pcie)
> res_start = res->start;
>
> rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPARH(win));
> - rcar_pci_write_reg(pcie, lower_32_bits(res_start), PCIEPARL(win));
> + rcar_pci_write_reg(pcie, lower_32_bits(res_start) & ~0x7F,
> + PCIEPARL(win));
>
> /* First resource is for IO */
> mask = PAR_ENABLE;
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-24 6:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-02 5:09 [PATCH] PCI: rcar: Add mask of data to be written to PCIEPARL Nobuhiro Iwamatsu
2015-02-03 18:53 ` Phil Edworthy
2015-02-24 2:02 ` Simon Horman
2015-02-24 6:25 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).