From: Bjorn Helgaas <bhelgaas@google.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: linux-pci@vger.kernel.org, phil.edworthy@renesas.com,
horms+renesas@verge.net.au
Subject: Re: [PATCH] PCI: rcar: Change macro name of PCIEPARL and PCIEPARH
Date: Tue, 24 Feb 2015 00:26:05 -0600 [thread overview]
Message-ID: <20150224062605.GC6220@google.com> (raw)
In-Reply-To: <1423040575-28080-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Wed, Feb 04, 2015 at 06:02:55PM +0900, Nobuhiro Iwamatsu wrote:
> PCIEPARL and PCIEPARH are macro that calculates address of the register.
> However, register name is incorrect, PCIEPALR and PCIEPAUR is correct.
> This change macro name to PCIEPALR and PCIEPAUR.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied to pci/host-rcar for v4.1, thanks!
> ---
> drivers/pci/host/pcie-rcar.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index eb12659..183c32d 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -64,8 +64,8 @@
> #define LAR_ENABLE (1 << 1)
>
> /* PCIe address reg & mask */
> -#define PCIEPARL(x) (0x03400 + ((x) * 0x20))
> -#define PCIEPARH(x) (0x03404 + ((x) * 0x20))
> +#define PCIEPALR(x) (0x03400 + ((x) * 0x20))
> +#define PCIEPAUR(x) (0x03404 + ((x) * 0x20))
> #define PCIEPAMR(x) (0x03408 + ((x) * 0x20))
> #define PCIEPTCTLR(x) (0x0340c + ((x) * 0x20))
> #define PAR_ENABLE (1 << 31)
> @@ -341,9 +341,9 @@ static void rcar_pcie_setup_window(int win, struct rcar_pcie *pcie)
> else
> res_start = res->start;
>
> - rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPARH(win));
> + rcar_pci_write_reg(pcie, upper_32_bits(res_start), PCIEPAUR(win));
> rcar_pci_write_reg(pcie, lower_32_bits(res_start) & ~0x7F,
> - PCIEPARL(win));
> + PCIEPALR(win));
>
> /* First resource is for IO */
> mask = PAR_ENABLE;
> --
> 2.1.3
>
prev parent reply other threads:[~2015-02-24 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 9:02 [PATCH] PCI: rcar: Change macro name of PCIEPARL and PCIEPARH Nobuhiro Iwamatsu
2015-02-04 9:14 ` Phil Edworthy
2015-02-05 0:35 ` Simon Horman
2015-02-24 2:03 ` Simon Horman
2015-02-24 6:26 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224062605.GC6220@google.com \
--to=bhelgaas@google.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).