* [PATCH] PCI: xgene: Fix the map_bus callback prototype
@ 2015-02-23 10:21 Phong Tran
2015-02-23 11:23 ` Arnd Bergmann
2015-02-26 1:18 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Phong Tran @ 2015-02-23 10:21 UTC (permalink / raw)
To: tinamdar, bhelgaas, linux-pci; +Cc: linux-arm-kernel, linux-kernel, Phong Tran
The return value should be void __iomem *.
Tested by compile only.
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/pci/host/pci-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index aab5547..9c3bfd8 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
return false;
}
-static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
+static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
int offset)
{
struct xgene_pcie_port *port = bus->sysdata;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: xgene: Fix the map_bus callback prototype
2015-02-23 10:21 [PATCH] PCI: xgene: Fix the map_bus callback prototype Phong Tran
@ 2015-02-23 11:23 ` Arnd Bergmann
2015-02-26 1:18 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-02-23 11:23 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Phong Tran, tinamdar, bhelgaas, linux-pci, linux-kernel
On Monday 23 February 2015 17:21:39 Phong Tran wrote:
> The return value should be void __iomem *.
> Tested by compile only.
>
> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the fix, I had noticed this in the build bot logs
but not yet reported on the list.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: xgene: Fix the map_bus callback prototype
2015-02-23 10:21 [PATCH] PCI: xgene: Fix the map_bus callback prototype Phong Tran
2015-02-23 11:23 ` Arnd Bergmann
@ 2015-02-26 1:18 ` Bjorn Helgaas
2015-02-26 1:23 ` Bjorn Helgaas
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2015-02-26 1:18 UTC (permalink / raw)
To: Phong Tran
Cc: tinamdar, linux-pci, linux-arm-kernel, linux-kernel,
Fabio Estevam
[+cc Fabio]
On Mon, Feb 23, 2015 at 05:21:39PM +0700, Phong Tran wrote:
> The return value should be void __iomem *.
> Tested by compile only.
>
> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
I've already applied an identical patch from Fabio Estevam. I added
Arnd's ack to it and also mentioned you in the credits, Phong.
> ---
> drivers/pci/host/pci-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> index aab5547..9c3bfd8 100644
> --- a/drivers/pci/host/pci-xgene.c
> +++ b/drivers/pci/host/pci-xgene.c
> @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
> return false;
> }
>
> -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> int offset)
> {
> struct xgene_pcie_port *port = bus->sysdata;
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PCI: xgene: Fix the map_bus callback prototype
2015-02-26 1:18 ` Bjorn Helgaas
@ 2015-02-26 1:23 ` Bjorn Helgaas
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2015-02-26 1:23 UTC (permalink / raw)
To: Phong Tran
Cc: tinamdar, linux-pci, linux-arm-kernel, linux-kernel,
Fabio Estevam
On Wed, Feb 25, 2015 at 07:18:24PM -0600, Bjorn Helgaas wrote:
> [+cc Fabio]
>
> On Mon, Feb 23, 2015 at 05:21:39PM +0700, Phong Tran wrote:
> > The return value should be void __iomem *.
> > Tested by compile only.
> >
> > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
>
> I've already applied an identical patch from Fabio Estevam. I added
> Arnd's ack to it and also mentioned you in the credits, Phong.
Dropped in favor of a more complete fix:
https://patchwork.ozlabs.org/patch/440759/
> > ---
> > drivers/pci/host/pci-xgene.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> > index aab5547..9c3bfd8 100644
> > --- a/drivers/pci/host/pci-xgene.c
> > +++ b/drivers/pci/host/pci-xgene.c
> > @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
> > return false;
> > }
> >
> > -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > int offset)
> > {
> > struct xgene_pcie_port *port = bus->sysdata;
> > --
> > 2.1.0
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-26 1:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 10:21 [PATCH] PCI: xgene: Fix the map_bus callback prototype Phong Tran
2015-02-23 11:23 ` Arnd Bergmann
2015-02-26 1:18 ` Bjorn Helgaas
2015-02-26 1:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).