linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups
Date: Mon, 30 Mar 2015 01:15:39 +0200	[thread overview]
Message-ID: <20150330011539.4bfa5288@kant> (raw)
In-Reply-To: <1427635734-24786-1-git-send-email-mst@redhat.com>

On Mar 29 Michael S. Tsirkin wrote:
> The macros in pci_ids.h are pretty useful for userspace
> using the pci sysfs interface, e.g. to decode class
> device and vendor sysfs files.
> 
> At the moment userspace is forced to duplicate these macros (e.g. QEMU does
> this, so does gpxe, seabios, etc), it is better to export them in
> /usr/include/linux/pci_ids.h so everyone can just include this header.
> 
> This patchset is structured as follows:
> 1. include/linux/pci_ids.h is moved to include/uapi/linux/pci_ids.h;
>    a stub file is created in include/linux/pci_ids.h to avoid breaking
>    bisect

Since linux' include/linux/pci_ids.h is incomplete, I am doubtful that it
is appropriate for userspace.

> 2. all users are converted to use the new header

This step should not be necessary.  It has not been done with other
headers which were moved to include/uapi.

> 3. include/linux/pci_ids.h is removed
> 4. cleanups for several issues detected during step 2

-- 
Stefan Richter
-=====-===== --== ====-
http://arcgraph.de/sr/

  parent reply	other threads:[~2015-03-29 23:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-29 13:36 [PATCH 00/86] pci: export pci_ids.h and related cleanups Michael S. Tsirkin
2015-03-29 13:37 ` [PATCH 01/86] pci: export pci_ids.h Michael S. Tsirkin
2015-03-29 15:49   ` Joe Perches
2015-03-29 20:40   ` Greg KH
2015-03-30  6:48     ` Michael S. Tsirkin
2015-03-30  6:55       ` Greg KH
2015-03-30  7:15         ` Michael S. Tsirkin
2015-03-30  7:53           ` Greg KH
2015-03-30  8:31             ` Michael S. Tsirkin
2015-03-30 10:07               ` Greg KH
2015-03-30 10:46                 ` Michael S. Tsirkin
2015-03-30 10:57                   ` Greg KH
2015-03-30 11:19                     ` Michael S. Tsirkin
2015-03-30 11:35                       ` Greg KH
2015-03-30 11:41                         ` Michael S. Tsirkin
2015-03-29 13:38 ` [PATCH 12/86] x86/pci/sta2x11: use uapi/linux/pci_ids.h directly Michael S. Tsirkin
2015-03-29 13:41 ` [PATCH 58/86] pci-label: " Michael S. Tsirkin
2015-03-29 13:43 ` [PATCH 77/86] linux/pci: " Michael S. Tsirkin
2015-03-29 13:43 ` [PATCH 78/86] linux/pci: drop include/linux/pci_ids.h Michael S. Tsirkin
2015-03-29 17:59 ` [PATCH 00/86] pci: export pci_ids.h and related cleanups Joe Perches
2015-03-30  6:52   ` Michael S. Tsirkin
2015-03-29 23:15 ` Stefan Richter [this message]
2015-04-02  7:44 ` Jean Delvare
2015-04-02  7:49   ` Michael S. Tsirkin
2015-04-02  8:23     ` Christoph Hellwig
2015-04-02  9:04       ` Jean Delvare
2015-04-02 10:09         ` Michael S. Tsirkin
2015-04-02 11:15           ` Jean Delvare
2015-04-02 12:05             ` Michael S. Tsirkin
2015-04-02 13:17               ` Jean Delvare
2015-04-02 12:09       ` Michael S. Tsirkin
2015-04-02 14:34         ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150330011539.4bfa5288@kant \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).