From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"robh@kernel.org" <robh@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Query] Direction of adding arm64 support to PCIe designware driver
Date: Wed, 8 Apr 2015 11:32:22 +0100 [thread overview]
Message-ID: <20150408103222.GB22376@red-moon> (raw)
In-Reply-To: <20150403174621.02681f0d@xhacker>
Hi Jisheng,
On Fri, Apr 03, 2015 at 10:46:21AM +0100, Jisheng Zhang wrote:
> Hi all,
>
> Currently, the pci designware driver still lacks of arm64 support and I noticed
> that many works are done to achieve this goal.
>
> Some patches are merged and some are under discussion. And Per my understanding,
> even w/ these patches merged, the driver still doesn't support arm64. Could you
> please kindly point out the direction to add arm64 support to the PCIe
> designware driver?
We should remove pci_sys_data dependency since ARM depends on that.
I removed it from a couple of places already (eg pci_mmap_page_range).
Now, pcibios_align_resource and pcibios_msi_controller need patching.
I have a patch for pcibios_align_resource() (I am waiting for Yijing
Wang series to get merged so that we can move the align_resource
function pointer in the host bridge):
https://lkml.org/lkml/2015/4/3/171
For MSI, code converted to use CONFIG_PCI_MSI_IRQ_DOMAIN should
not need pcibios_msi_controller ARM function, but if we still compile
that function in we do need pci_sys_data on ARM, so we have to have
it even if it can be dead code in some platforms, I have to vet all
ARM PCI host controllers to check, but removing it would break MSI
support.
Does it help ? MSIs are the most important change required,
align_resource() pointer can be sorted out easily once Yijing's
code gets in.
Lorenzo
next prev parent reply other threads:[~2015-04-08 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:46 [Query] Direction of adding arm64 support to PCIe designware driver Jisheng Zhang
2015-04-08 10:32 ` Lorenzo Pieralisi [this message]
2015-04-09 1:36 ` Jaehoon Chung
2015-04-09 2:43 ` Jisheng Zhang
2015-04-09 2:47 ` Minghuan.Lian
2015-04-09 3:29 ` Jisheng Zhang
2015-04-13 9:16 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408103222.GB22376@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).