From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp08.au.ibm.com ([202.81.31.141]:50334 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbbELGRB (ORCPT ); Tue, 12 May 2015 02:17:01 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 May 2015 16:16:58 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 84F5F2BB0040 for ; Tue, 12 May 2015 16:16:57 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4C6GmMq27394050 for ; Tue, 12 May 2015 16:16:57 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4C6GOmr023895 for ; Tue, 12 May 2015 16:16:24 +1000 Date: Tue, 12 May 2015 16:15:58 +1000 From: Gavin Shan To: Wei Yang Cc: Gavin Shan , bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: Re: [PATCH V3 2/9] powerpc/pci_dn: cache vf_index in pci_dn Message-ID: <20150512061558.GA18734@gwshan> Reply-To: Gavin Shan References: <1430723258-21299-1-git-send-email-weiyang@linux.vnet.ibm.com> <1430723258-21299-3-git-send-email-weiyang@linux.vnet.ibm.com> <20150511022104.GA7459@gwshan> <20150511055412.GA1632@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150511055412.GA1632@richard> Sender: linux-pci-owner@vger.kernel.org List-ID: On Mon, May 11, 2015 at 01:54:12PM +0800, Wei Yang wrote: >On Mon, May 11, 2015 at 12:21:04PM +1000, Gavin Shan wrote: >>On Mon, May 04, 2015 at 03:07:31PM +0800, Wei Yang wrote: >>>This patch caches the index of a VF in its PF in pci_dn. >>> >> >>At least you can mention the purpose of vf_index to make the commit log >>complete. The following message looks better? >> >>The patch caches the VF index in pci_dn, which can be used to calculate >>VF's bus, device and function number. Those information helps to locate >>the VF's PCI device instance when doing hotplug during EEH recovery if >>necessary. >> > >Thanks, looks better. I added it in the log. > >>>Signed-off-by: Wei Yang >>>--- >>> arch/powerpc/include/asm/pci-bridge.h | 1 + >>> arch/powerpc/kernel/pci_dn.c | 5 +++-- >>> 2 files changed, 4 insertions(+), 2 deletions(-) >>> >>>diff --git a/arch/powerpc/include/asm/pci-bridge.h b/arch/powerpc/include/asm/pci-bridge.h >>>index 1811c44..9582aa2 100644 >>>--- a/arch/powerpc/include/asm/pci-bridge.h >>>+++ b/arch/powerpc/include/asm/pci-bridge.h >>>@@ -199,6 +199,7 @@ struct pci_dn { >>> #ifdef CONFIG_PCI_IOV >>> u16 vfs_expanded; /* number of VFs IOV BAR expanded */ >>> u16 num_vfs; /* number of VFs enabled*/ >>>+ int vf_index; /* Index to PF for VF dev */ >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> /* VF index in the PF */ > >Ok, changed in the code. > >> >>And I believe it can be "unsigned int", or u16. We should have >>non-negative vf_index, no? > >Take a look in the virtfn_add(), the index in drivers/pci/iov.c is int. So I >copy that. > >> >>> int offset; /* PE# for the first VF PE */ >>> #define M64_PER_IOV 4 >>> int m64_per_iov; >>>diff --git a/arch/powerpc/kernel/pci_dn.c b/arch/powerpc/kernel/pci_dn.c >>>index b3b4df9..bf0fb873 100644 >>>--- a/arch/powerpc/kernel/pci_dn.c >>>+++ b/arch/powerpc/kernel/pci_dn.c >>>@@ -138,7 +138,7 @@ struct pci_dn *pci_get_pdn(struct pci_dev *pdev) >>> >>> #ifdef CONFIG_PCI_IOV >>> static struct pci_dn *add_one_dev_pci_data(struct pci_dn *parent, >>>- struct pci_dev *pdev, >>>+ struct pci_dev *pdev, int vf_index, >> >> struct pci_dev *pdev, >> int vf_index; > >Some reason for this comment? > >That does not exceed 80 characters. > No, it doesn't exceed 80 characters as you said. You take one of the following formats, not the one you're using: add_one_dev_pci_data(foo1, foo2, add_one_dev_pci_data(foo1, foo3, foo4, foo2, foo5, foo6); : foo6); >>> int busno, int devfn) >>> { >>> struct pci_dn *pdn; >>>@@ -157,6 +157,7 @@ static struct pci_dn *add_one_dev_pci_data(struct pci_dn *parent, >>> pdn->parent = parent; >>> pdn->busno = busno; >>> pdn->devfn = devfn; >>>+ pdn->vf_index = vf_index; >>> #ifdef CONFIG_PPC_POWERNV >>> pdn->pe_number = IODA_INVALID_PE; >>> #endif >>>@@ -196,7 +197,7 @@ struct pci_dn *add_dev_pci_data(struct pci_dev *pdev) >>> return NULL; >>> >>> for (i = 0; i < pci_sriov_get_totalvfs(pdev); i++) { >>>- pdn = add_one_dev_pci_data(parent, NULL, >>>+ pdn = add_one_dev_pci_data(parent, NULL, i, >>> pci_iov_virtfn_bus(pdev, i), >>> pci_iov_virtfn_devfn(pdev, i)); >>> if (!pdn) { Thanks, Gavin