From: David Miller <davem@davemloft.net>
To: bhelgaas@google.com
Cc: aleksey.makarov@auriga.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, david.daney@cavium.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id
Date: Sat, 16 May 2015 17:14:44 -0400 (EDT) [thread overview]
Message-ID: <20150516.171444.245757401088795324.davem@davemloft.net> (raw)
In-Reply-To: <CAErSpo4fLHEu_NOuy9CkrS9DOfSyCOkddPHEQz=pp6et8wa2AA@mail.gmail.com>
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Sat, 16 May 2015 09:49:40 -0500
> Hi Aleksey,
>
> On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov
> <aleksey.makarov@auriga.com> wrote:
>> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>
>> ---
>> include/linux/pci_ids.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index e63c02a..3633cc6 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2327,6 +2327,8 @@
>> #define PCI_DEVICE_ID_ALTIMA_AC9100 0x03ea
>> #define PCI_DEVICE_ID_ALTIMA_AC1003 0x03eb
>>
>> +#define PCI_VENDOR_ID_CAVIUM 0x177d
>
> Please read the note at the top of include/linux/pci_ids.h. If this
> definition is used in two or more drivers, mention that in the
> changelog. Otherwise, just use the bare hex value or a private
> #define in your driver.
It is referenced from two foo.c files in the same driver.
I don't know what policy we want for situations like that.
next prev parent reply other threads:[~2015-05-16 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431747401-20847-1-git-send-email-aleksey.makarov@auriga.com>
2015-05-16 3:36 ` [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id Aleksey Makarov
2015-05-16 14:49 ` Bjorn Helgaas
2015-05-16 21:14 ` David Miller [this message]
2015-05-18 16:35 ` Bjorn Helgaas
2015-05-18 16:41 ` David Miller
2015-05-18 17:26 ` Bjorn Helgaas
2015-05-18 17:51 ` David Daney
2015-05-18 21:00 ` Aleksey Makarov
2015-05-18 21:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516.171444.245757401088795324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aleksey.makarov@auriga.com \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).