From: Christoph Hellwig <hch@infradead.org>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu,
gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org,
jkosina@suse.cz, bhelgaas@google.com, linux-pci@vger.kernel.org,
xen-devel@lists.xenproject.org, bp@suse.de
Subject: Re: [PATCH] Documentation: extend use case for EXPORT_SYMBOL_GPL()
Date: Thu, 28 May 2015 22:00:09 -0700 [thread overview]
Message-ID: <20150529050009.GA26034@infradead.org> (raw)
In-Reply-To: <20150528231044.GY23057@wotan.suse.de>
On Fri, May 29, 2015 at 01:10:44AM +0200, Luis R. Rodriguez wrote:
> Great, thanks. This seems to be in alignment with those who have all along said
> they've used EXPORT_SYMBOL() to mean what EXPORT_SYMBOL_GPL() users now use it
> for. Nevertheless -- maintainers should know that some stubborn developers use
> EXPORT_SYMBOL_GPL() for its technical merit should violators abuse those
> symbols.
FYI, I think the naming here is really unfortunate. If if was named
EXPORT_SYMBOL_INTERNAL as just a kernel export for specific uses we'd
be much better off in being able to explain what it actually does.
Even better would e a system were we have specific export groups, e.g.
symbols would be "core" "mm", "vfs", or "legacy_hack_for_drm" and any
consumer would specificly declare which symbol they pull in.
This would have a couple advantages:
- anyone adding an export needs to think hard into which category
it falls, and think again if exporting really makes sense
- it's reasy to review modules to see if they pull in anything
unexpected.
next prev parent reply other threads:[~2015-05-29 5:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 18:56 [PATCH] Documentation: extend use case for EXPORT_SYMBOL_GPL() Luis R. Rodriguez
2015-05-28 19:09 ` Jonathan Corbet
2015-05-28 19:18 ` Luis R. Rodriguez
2015-05-28 19:35 ` Jonathan Corbet
2015-05-28 20:07 ` Al Viro
2015-05-28 21:17 ` Luis R. Rodriguez
2015-05-28 21:56 ` Al Viro
2015-05-28 23:10 ` Luis R. Rodriguez
2015-05-29 5:00 ` Christoph Hellwig [this message]
2015-05-29 17:40 ` Luis R. Rodriguez
2015-05-29 1:30 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529050009.GA26034@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@elte.hu \
--cc=viro@ZenIV.linux.org.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox