linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Michael Marineau <michael.marineau@coreos.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	platform-driver-x86@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Petri Hodju <petrihodju@yahoo.com>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [Patch v3] apple-gmux: lock iGP IO to protect from vgaarb changes
Date: Mon, 1 Jun 2015 19:31:58 +0200	[thread overview]
Message-ID: <20150601173158.GA87111@vmdeb7> (raw)
In-Reply-To: <20150601082227.01663ac8@pluto.restena.lu>

On Mon, Jun 01, 2015 at 08:22:27AM +0200, Bruno Prémont wrote:
> On Fri, 29 May 2015 18:36:50 +0200 Darren Hart wrote:
> > > Making sure to lock only the intel GPU when present and especially protecting
> > > against nvidia driver will be hard if legacy-IO is being processed by a hidden
> > > device!
> > 
> > Ugh indeed. Worst case we can special case via dmi strings. Is this Apple device
> > significantly different from others? Bruno, what are you testing on?
> 
> I only own a pretty old MacBook Air with just NVIDIA IGP and had to
> rely on BUG reports and testing from affected users.
> 
> Not doing anything on apple-gmux when only a single GPU is visible
> should be easy, but denying any vgaarb operation when Intel IGP is
> hidden and just discrete GPU present is much harder (if one does not
> want to risk opening the next can of worms).
> 
> DMI based special-casing would work but will it uncover the next issue
> with the same device configured differently?

No, we would need a combination. I presume "configured differently" would mean
the Intel GPU present - which would be detectable.

DMI + Nvidia = do A
DMI + Intel = do B

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2015-06-01 17:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150223215155.18444386@neptune.home>
     [not found] ` <20150303172753.GF83894@vmdeb7>
     [not found]   ` <20150305232038.1873d380@neptune.home>
     [not found]     ` <20150306174254.GB19001@vmdeb7>
     [not found]       ` <20150307011546.0050279d@neptune.home>
2015-03-09 21:52         ` [Patch v2 resend] apple-gmux: lock iGP IO to protect from vgaarb changes Bruno Prémont
2015-03-09 22:11           ` Bjorn Helgaas
2015-03-11 21:34             ` [Patch v3] " Bruno Prémont
2015-03-19  3:46               ` Darren Hart
2015-05-26 19:10               ` Michael Marineau
2015-05-27  4:47                 ` Darren Hart
2015-05-27  5:35                   ` Michael Marineau
2015-05-27  6:13                     ` Bruno Prémont
2015-05-27  6:41                       ` Michael Marineau
2015-05-29 16:36                       ` Darren Hart
2015-06-01  6:22                         ` Bruno Prémont
2015-06-01 17:31                           ` Darren Hart [this message]
2015-05-27  5:53                   ` Bruno Prémont
2015-05-27  6:28                     ` Michael Marineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150601173158.GA87111@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=bonbons@linux-vserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=michael.marineau@coreos.com \
    --cc=petrihodju@yahoo.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).