From: Bjorn Helgaas <bhelgaas@google.com>
To: Allen Hubbe <Allen.Hubbe@emc.com>
Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Jon Mason <jdmason@kudzu.us>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v3 02/18] NTB: Add NTB hardware abstraction layer
Date: Tue, 9 Jun 2015 11:53:28 -0500 [thread overview]
Message-ID: <20150609165328.GH23119@google.com> (raw)
In-Reply-To: <21347a93355f40d945cf9f565f95e790d9b3bda5.1433838377.git.Allen.Hubbe@emc.com>
On Tue, Jun 09, 2015 at 05:44:29AM -0400, Allen Hubbe wrote:
> Abstract the ntb device behind a programming interface, so that it can
> support different hardware. Change the intel hardware driver to fit the
> abstraction.
>
> Expose the ntb hardware api to client drivers instead of tying it to
> ntb_transport. Make ntb_transport a client of the ntb hardware api.
>
> Signed-off-by: Allen Hubbe <Allen.Hubbe@emc.com>
> ---
>
> It was pointed out in v1 that this one patch is over 200KB. Please
> accept my appologies for not breaking this down further. The affected
> components in this patch had interdependencies, which makes it difficult
> to contain the changes. This change separates the components, so future
> changes can be better contained.
>
> Documentation/ntb.txt | 58 +
> MAINTAINERS | 14 +-
> drivers/net/ntb_netdev.c | 58 +-
> drivers/ntb/Kconfig | 37 +-
> drivers/ntb/Makefile | 4 +-
> drivers/ntb/hw/Kconfig | 1 +
> drivers/ntb/hw/Makefile | 1 +
> drivers/ntb/hw/intel/Kconfig | 7 +
> drivers/ntb/hw/intel/Makefile | 1 +
> drivers/ntb/hw/intel/ntb_hw_intel.c | 3077 +++++++++++++++++++----------------
> drivers/ntb/hw/intel/ntb_hw_intel.h | 607 ++++---
> drivers/ntb/ntb.c | 251 +++
> drivers/ntb/ntb_transport.c | 944 ++++++-----
> include/linux/ntb.h | 984 +++++++++++
> include/linux/ntb_transport.h | 25 +-
> 15 files changed, 3870 insertions(+), 2199 deletions(-)
> create mode 100644 Documentation/ntb.txt
> create mode 100644 drivers/ntb/hw/Kconfig
> create mode 100644 drivers/ntb/hw/Makefile
> create mode 100644 drivers/ntb/hw/intel/Kconfig
> create mode 100644 drivers/ntb/hw/intel/Makefile
> create mode 100644 drivers/ntb/ntb.c
> create mode 100644 include/linux/ntb.h
I'm not really a reviewer (I'm only commenting on obvious English and
spelling issues), so maybe the real reviewers can handle this. But if I
were reviewing the code, this patch would be far too large for me to make
sense of.
And it makes bisection and reversion significantly less useful.
Bjorn
next prev parent reply other threads:[~2015-06-09 16:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:44 [PATCH v3 00/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 01/18] NTB: Move files in preparation for NTB abstraction Allen Hubbe
2015-06-09 16:16 ` Bjorn Helgaas
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 02/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 16:23 ` Bjorn Helgaas
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:53 ` Bjorn Helgaas [this message]
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 03/18] NTB: Read peer info from local SPAD in transport Allen Hubbe
2015-06-09 16:24 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 04/18] NTB: Enable link for Intel root port mode in probe Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 05/18] NTB: Check the device ID to set errata flags Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 06/18] NTB: Differentiate transport link down messages Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 07/18] NTB: Do not advance transport RX on link down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 08/18] NTB: Reset transport QP link stats on down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 09/18] NTB: Add parameters for Intel SNB B2B addresses Allen Hubbe
2015-06-09 16:42 ` Bjorn Helgaas
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 10/18] NTB: Add ping pong test client Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 11/18] NTB: Add tool " Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 12/18] NTB: Rate limit ntb_qp_link_work Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 13/18] NTB: Use NUMA memory and DMA chan in transport Allen Hubbe
2015-06-09 16:43 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 14/18] NTB: Use NUMA memory in Intel driver Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 15/18] NTB: Improve performance with write combining Allen Hubbe
2015-06-09 16:46 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 16/18] NTB: Default to CPU memcpy for performance Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 17/18] NTB: Rename intel hw to proper platform names Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Allen Hubbe
2015-06-09 16:04 ` Bjorn Helgaas
2015-06-09 16:45 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609165328.GH23119@google.com \
--to=bhelgaas@google.com \
--cc=Allen.Hubbe@emc.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).