From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: "Ville Syrjälä" <syrjala@sci.fi>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Borislav Petkov" <bp@suse.de>, "Ingo Molnar" <mingo@elte.hu>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Andy Lutomirski" <luto@amacapital.net>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-fbdev <linux-fbdev@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Dave Airlie" <airlied@redhat.com>,
"Toshi Kani" <toshi.kani@hp.com>,
"Suresh Siddha" <sbsiddha@gmail.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Juergen Gross" <jgross@suse.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Antonino Daplas" <adaplas@gmail.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Rob Clark" <robdclark@gmail.com>,
"Mathias Krause" <minipli@googlemail.com>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Mel Gorman" <mgorman@suse.de>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Davidlohr Bueso" <dbueso@suse.de>
Subject: Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used
Date: Fri, 26 Jun 2015 03:09:27 +0200 [thread overview]
Message-ID: <20150626010927.GI3005@wotan.suse.de> (raw)
In-Reply-To: <20150625231103.GB4362@sci.fi>
On Fri, Jun 26, 2015 at 02:11:03AM +0300, Ville Syrjälä wrote:
> On Thu, Jun 25, 2015 at 04:06:45PM -0700, Luis R. Rodriguez wrote:
> > On Thu, Jun 25, 2015 at 4:04 PM, Ville Syrjälä <syrjala@sci.fi> wrote:
> > > it doesn't hurt too much
> > > since smem_len gets overwritten later in aty_init().
> >
> > That's the idea, we set it with a default as it will be overwritten
> > later anyway.
>
> Maybe toss in a comment? Otherwise it's a bit dishonest and might give
> someone the impression that all PCI cards really have 8MB of memory.
Sure, mind this as a follow up patch if its too late?
Luis
next prev parent reply other threads:[~2015-06-26 1:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 1:34 [PATCH v5 0/3] atyfb: address MTRR corner case Luis R. Rodriguez
2015-06-25 1:34 ` [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used Luis R. Rodriguez
2015-06-25 23:04 ` Ville Syrjälä
2015-06-25 23:06 ` Luis R. Rodriguez
2015-06-25 23:11 ` Ville Syrjälä
2015-06-26 1:09 ` Luis R. Rodriguez [this message]
2015-06-26 7:30 ` Borislav Petkov
2015-07-02 23:23 ` Luis R. Rodriguez
2015-07-08 0:24 ` Luis R. Rodriguez
2015-07-08 8:38 ` Ville Syrjälä
2015-07-09 17:25 ` Luis R. Rodriguez
2015-06-25 1:34 ` [PATCH v5 2/3] video: fbdev: atyfb: replace MTRR UC hole with strong UC Luis R. Rodriguez
2015-06-25 1:34 ` [PATCH v5 3/3] video: fbdev: atyfb: use arch_phys_wc_add() and ioremap_wc() Luis R. Rodriguez
2015-06-25 16:43 ` [PATCH v5 0/3] atyfb: address MTRR corner case Luis R. Rodriguez
2015-06-25 20:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626010927.GI3005@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=a.hajda@samsung.com \
--cc=adaplas@gmail.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dbueso@suse.de \
--cc=jgross@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@do-not-panic.com \
--cc=mgorman@suse.de \
--cc=mingo@elte.hu \
--cc=minipli@googlemail.com \
--cc=mst@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=robdclark@gmail.com \
--cc=sbsiddha@gmail.com \
--cc=syrjala@sci.fi \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hp.com \
--cc=vbabka@suse.cz \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).