From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: bhelgaas@google.com, linux-pci@vger.kernel.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Allen Kay <allen.m.kay@intel.com>,
Chris Wright <chris@sous-sol.org>
Subject: [PATCH] pcie: Restore ACS configuration as part of pci_restore_state
Date: Tue, 07 Jul 2015 12:24:35 -0700 [thread overview]
Message-ID: <20150707192434.8444.74316.stgit@ahduyck-server> (raw)
This change is meant to address the fact that ACS state was not being
restored as a part of the PCI configuration restoration following a PCIe
reset. Without this patch it is not possible to reassign interfaces behind
ACS enabled switches following a system suspend as all of the ACS
functionality is disabled due to the D0->D3->D0 state transition cycle
clearing the configuration state and the fact that the ACS logic was only
initialized in probe.
Cc: Allen Kay <allen.m.kay@intel.com>
Cc: Chris Wright <chris@sous-sol.org>
Cc: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
drivers/pci/pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 0008c950452c..9bd9526f3388 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1092,6 +1092,9 @@ void pci_restore_state(struct pci_dev *dev)
pci_restore_pcix_state(dev);
pci_restore_msi_state(dev);
+
+ /* Restore ACS and IOV configuration state */
+ pci_enable_acs(dev);
pci_restore_iov_state(dev);
dev->state_saved = false;
next reply other threads:[~2015-07-07 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 19:24 Alexander Duyck [this message]
2015-07-21 15:47 ` [PATCH] pcie: Restore ACS configuration as part of pci_restore_state Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707192434.8444.74316.stgit@ahduyck-server \
--to=alexander.h.duyck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=allen.m.kay@intel.com \
--cc=bhelgaas@google.com \
--cc=chris@sous-sol.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).