linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: jakeo@microsoft.com, olaf@aepfle.de, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, bhelgaas@google.com,
	linux-pci@vger.kernel.org, apw@canonical.com,
	devel@linuxdriverproject.org, tglx@linutronix.de
Subject: Re: [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs
Date: Mon, 3 Aug 2015 12:52:50 +0300	[thread overview]
Message-ID: <20150803093534.GV5180@mwanda> (raw)
In-Reply-To: <1438593492.3726.13.camel@tiscali.nl>

On Mon, Aug 03, 2015 at 11:18:12AM +0200, Paul Bolle wrote:
> On zo, 2015-08-02 at 00:54 +0000, jakeo@microsoft.com wrote:
> > --- /dev/null
> > +++ b/drivers/pci/host/hv_pcifront.c
> 
> > +static void exit_hv_pci_drv(void)
> > +{
> > +	vmbus_driver_unregister(&hv_pci_drv);
> > +}
> > +
> > +static int __init init_hv_pci_drv(void)
> > +{
> > +	int ret;
> > +
> > +	/* Register this driver with VMBus. */
> > +	ret = vmbus_driver_register(&hv_pci_drv);
> > +
> > +	if (ret < 0)
> > +		exit_hv_pci_drv();
> > +
> > +	return ret;
> > +}
> 
> Wouldn't just
>     static int __init init_hv_pci_drv(void)
>     {
>     	return vmbus_driver_register(&hv_pci_drv);
>     }
> 
> suffice here?

You're right, of course.  The error handling is buggy.

regards,
dan carpenter


      reply	other threads:[~2015-08-03  9:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-02  0:54 [PATCH 0/4] New Paravirtual front-end for PCI in a Hyper-V VM jakeo
2015-08-02  0:54 ` [PATCH 1/4] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num jakeo
2015-08-02  0:54 ` [PATCH 2/4] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through jakeo
2015-08-02  0:54 ` [PATCH 3/4] drivers:x86:pci: Make it possible to implement a PCI MSI IRQ Domain in a module jakeo
2015-08-02  0:54 ` [PATCH 4/4] drivers:pci:hv: New paravirtual PCI front-end for Hyper-V VMs jakeo
2015-08-02  8:47   ` Thomas Gleixner
2015-08-03 19:19     ` Jake Oshins
2015-08-03 19:43       ` Thomas Gleixner
2015-08-03  9:18   ` Paul Bolle
2015-08-03  9:52     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150803093534.GV5180@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=apw@canonical.com \
    --cc=bhelgaas@google.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jakeo@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=pebolle@tiscali.nl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).