From: Will Deacon <will.deacon@arm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jayachandran C <jchandra@broadcom.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci
Date: Wed, 5 Aug 2015 10:25:34 +0100 [thread overview]
Message-ID: <20150805092533.GC6092@arm.com> (raw)
In-Reply-To: <20150805092318.GB6092@arm.com>
On Wed, Aug 05, 2015 at 10:23:18AM +0100, Will Deacon wrote:
> That said, I just tried to build this and it fails to compile the x-gene
> PCI host driver. Fixup below.
Wait, there's more!
Will
--->8
diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index 514f41b86c49..8ab3bd098424 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -506,7 +506,7 @@ static int xgene_pcie_msi_enable(struct xgene_pcie_port *port)
{
struct device_node *msi_node;
- msi_node = of_parse_phandle(port->dev.of_node, "msi-parent", 0);
+ msi_node = of_parse_phandle(port->dev->of_node, "msi-parent", 0);
if (!msi_node)
return -ENODEV;
@@ -515,7 +515,7 @@ static int xgene_pcie_msi_enable(struct xgene_pcie_port *port)
return -ENODEV;
of_node_put(msi_node);
- port->msi->dev = &port->dev;
+ port->msi->dev = port->dev;
return 0;
}
next prev parent reply other threads:[~2015-08-05 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 20:53 [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci Jayachandran C
2015-08-04 20:53 ` [PATCH v4 2/3] PCI: Add setup-irq.o when compiling for arm64 Jayachandran C
2015-08-04 20:53 ` [PATCH v4 3/3] PCI: generic: add arm64 support Jayachandran C
2015-08-04 23:49 ` [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci Bjorn Helgaas
2015-08-05 9:23 ` Will Deacon
2015-08-05 9:25 ` Will Deacon [this message]
2015-08-05 11:51 ` Bjorn Helgaas
2015-08-13 13:16 ` Suravee Suthikulpanit
2015-08-12 7:11 ` Pavel Fedin
2015-08-12 9:04 ` Will Deacon
2015-08-14 13:44 ` Pavel Fedin
2015-08-14 14:46 ` Bjorn Helgaas
2015-08-14 15:24 ` Lorenzo Pieralisi
2015-08-12 9:15 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805092533.GC6092@arm.com \
--to=will.deacon@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jchandra@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).