Re: [PATCH] PCI/ASPM: Fix a NULL pointer crash on sparc64

[David Miller <davem@davemloft.net>]

From: Bjorn Helgaas <bhelgaas@google.com>
Date: Thu, 20 Aug 2015 16:21:09 -0500

> On Thu, Aug 20, 2015 at 01:58:32PM -0700, David Miller wrote:
>> From: Bjorn Helgaas <bhelgaas@google.com>
>> Date: Thu, 20 Aug 2015 15:21:35 -0500
>> 
>> > On Thu, Aug 20, 2015 at 11:40:42AM -0700, David Miller wrote:
>> >> From: Bjorn Helgaas <bhelgaas@google.com>
>> >> Date: Thu, 20 Aug 2015 11:23:43 -0700
>> >> 
>> >> > On Thu, Aug 20, 2015 at 10:47 AM, David Miller <davem@davemloft.net> wrote:
>> >> >> From: Bjorn Helgaas <bhelgaas@google.com>
>> >> >> Date: Thu, 20 Aug 2015 00:48:00 -0500
>> >> >>
>> >> >>> [+cc Dave, Eric, Ben, sparclinux]
>> >> >>
>> >> >> I think the comment is terrible.
>> >> > 
>> >> > I'll update the comment if you suggest some text.  Do you object
>> >> > mainly to the mention of the specific systems?
>> >> 
>> >> "PCI root complex can not be assumed to be instantiated in the PCI bus
>> >>  hierarchy."
>> > 
>> > AIUI, the root complex itself (as distinct from root ports) doesn't
>> > normally appear in the PCI hierarchy, so I reworded it as follows.  I hope
>> > this helps address your objection, but if not, I can try again.
>> 
>> This is fine, but it was the comment we were talking about adjusting not
>> the commit message :-)
> 
> Oh, sorry!  I totally misread that.  Here's another try.

This also looks fine:

Acked-by: David S. Miller <davem@davemloft.net>