From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([149.20.54.216]:57342 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849AbbHTViQ (ORCPT ); Thu, 20 Aug 2015 17:38:16 -0400 Date: Thu, 20 Aug 2015 14:38:15 -0700 (PDT) Message-Id: <20150820.143815.1802014224351735588.davem@davemloft.net> To: bhelgaas@google.com Cc: wangyijing@huawei.com, linux-pci@vger.kernel.org, mroos@linux.ee, sparclinux@vger.kernel.org, eric.snowberg@oracle.com, benh@kernel.crashing.org Subject: Re: [PATCH] PCI/ASPM: Fix a NULL pointer crash on sparc64 From: David Miller In-Reply-To: <20150820212109.GB14810@google.com> References: <20150820202135.GA14810@google.com> <20150820.135832.47467691959908917.davem@davemloft.net> <20150820212109.GB14810@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: linux-pci-owner@vger.kernel.org List-ID: From: Bjorn Helgaas Date: Thu, 20 Aug 2015 16:21:09 -0500 > On Thu, Aug 20, 2015 at 01:58:32PM -0700, David Miller wrote: >> From: Bjorn Helgaas >> Date: Thu, 20 Aug 2015 15:21:35 -0500 >> >> > On Thu, Aug 20, 2015 at 11:40:42AM -0700, David Miller wrote: >> >> From: Bjorn Helgaas >> >> Date: Thu, 20 Aug 2015 11:23:43 -0700 >> >> >> >> > On Thu, Aug 20, 2015 at 10:47 AM, David Miller wrote: >> >> >> From: Bjorn Helgaas >> >> >> Date: Thu, 20 Aug 2015 00:48:00 -0500 >> >> >> >> >> >>> [+cc Dave, Eric, Ben, sparclinux] >> >> >> >> >> >> I think the comment is terrible. >> >> > >> >> > I'll update the comment if you suggest some text. Do you object >> >> > mainly to the mention of the specific systems? >> >> >> >> "PCI root complex can not be assumed to be instantiated in the PCI bus >> >> hierarchy." >> > >> > AIUI, the root complex itself (as distinct from root ports) doesn't >> > normally appear in the PCI hierarchy, so I reworded it as follows. I hope >> > this helps address your objection, but if not, I can try again. >> >> This is fine, but it was the comment we were talking about adjusting not >> the commit message :-) > > Oh, sorry! I totally misread that. Here's another try. This also looks fine: Acked-by: David S. Miller