From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:56250 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbbHZMXO (ORCPT ); Wed, 26 Aug 2015 08:23:14 -0400 In-Reply-To: <1440420167-8879-2-git-send-email-mpe@ellerman.id.au> To: From: Michael Ellerman Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, mst@redhat.com, gpiccoli@linux.vnet.ibm.com Subject: Re: [2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case Message-Id: <20150826122313.9E26A140338@ozlabs.org> Date: Wed, 26 Aug 2015 22:23:13 +1000 (AEST) Sender: linux-pci-owner@vger.kernel.org List-ID: On Mon, 2015-24-08 at 12:42:47 UTC, Michael Ellerman wrote: > From: "Guilherme G. Piccoli" > > Since commit 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even if > kernel doesn't support MSI"), the setup of dev->msi_cap/msix_cap and the > disable of MSI/MSI-X interrupts isn't being done at PCI probe time, as > the logic responsible for this was moved in the aforementioned commit > from pci_device_add() to pci_setup_device(). The latter function is not > reachable on PowerPC pseries platform during Open Firmware PCI probing > time. > > This exhibits as drivers not being able to enable MSI, eg: > > bnx2x 0000:01:00.0: no msix capability found > > This patch calls pci_msi_setup_pci_dev() explicitly to disable MSI/MSI-X > during PCI probe time on pSeries platform. > > Fixes: 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even if kernel doesn't support MSI") > [mpe: Flesh out change log and clarify comment] > Signed-off-by: Guilherme G. Piccoli > Signed-off-by: Michael Ellerman Applied to powerpc fixes. https://git.kernel.org/powerpc/c/4d9aac397a5d8f4ee26a4178 cheers