From: Bjorn Helgaas <helgaas@kernel.org>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: bhelgaas@google.com, jingoohan1@gmail.com,
pratyush.anand@gmail.com, linux-pci@vger.kernel.org,
wangzhou1@hisilicon.com, yuanzhichang@hisilicon.com,
zhudacai@hisilicon.com, zhangjukuo@huawei.com,
qiuzhenfa@hisilicon.com, liguozhu@hisilicon.com
Subject: Re: [PATCH v2 ] PCI: Designware: make num-lanes an optional DT property
Date: Thu, 15 Oct 2015 15:00:58 -0500 [thread overview]
Message-ID: <20151015200058.GA10442@localhost> (raw)
In-Reply-To: <1443456190-225875-1-git-send-email-gabriele.paoloni@huawei.com>
On Tue, Sep 29, 2015 at 12:03:10AM +0800, Gabriele Paoloni wrote:
> From: gabriele paoloni <gabriele.paoloni@huawei.com>
>
> Currently num-lanes is read in dw_pcie_host_init().
> For a SoC that performs the link-up operation in UEFI, num-lanes
> is not needed in the DTS; however currently it has to be specified
> to some random value otherwise dw_pcie_host_init will fail.
> If the link is brought up in BIOS dw_pcie_setup_rc should not
> be called.
> This patch reworks dw_pcie_host_init() so that, if num-lanes is
> not specified, it sets pp->lanes = 0. If later on dw_pcie_setup_rc
> is called and pp->num_lanes is not set to a valid value,
> dw_pcie_setup_rc will send an error message and return.
>
> This patch is a follow-up of
> http://www.spinics.net/lists/linux-pci/msg44394.html
>
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Applied to pci/host-designware for v4.4 with changelog as follows,
thanks, Gabriele!
commit efe52075227729aa2a1ed55e34dd599b3bb0dbf1
Author: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Date: Tue Sep 29 00:03:10 2015 +0800
PCI: designware: Make num-lanes an optional DT property
Currently "num-lanes" is read in dw_pcie_host_init(), but it is only used
if we call dw_pcie_setup_rc() while bringing up the link. If the link has
already been brought up by firmware, we need not call dw_pcie_setup_rc(),
and "num-lanes" is unnecessary.
Only complain about "num-lanes" if we actually need it and we didn't find a
valid value.
[bhelgaas: changelog]
Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
next prev parent reply other threads:[~2015-10-15 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 16:03 [PATCH v2 ] PCI: Designware: make num-lanes an optional DT property Gabriele Paoloni
2015-10-15 20:00 ` Bjorn Helgaas [this message]
2015-10-16 6:26 ` Gabriele Paoloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015200058.GA10442@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=jingoohan1@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@gmail.com \
--cc=qiuzhenfa@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
--cc=yuanzhichang@hisilicon.com \
--cc=zhangjukuo@huawei.com \
--cc=zhudacai@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).