Re: [PATCH v7 37/50] powerpc/powernv: Simplify pnv_eeh_reset()

Gavin Shan
2015-11-12T06:12:55Z

On Thu, Nov 12, 2015 at 04:11:12PM +1100, Daniel Axtens wrote:
>> - rc = opal_pci_reset(phb->opal_id,
>> - OPAL_RESET_PHB_ERROR,
>> - OPAL_ASSERT_RESET);
>> - if (rc != OPAL_SUCCESS) {
>> - pr_warn("%s: Failure %lld clearing "
>> - "error injection registers\n",
>> - __func__, rc);
>
>This is very minor, but is there a good reason to change the error
>message from the one above to the one below? I just hesitate to change
>error messages that people might be grepping the source for without a
>good reason.
>

About 3 years ago, I think the error message printed by pr_warn() can't
exceed 80 lines each line. Otherwise, scripts/checkpatch.pl will report
warnings. The error message spans multiple lines to avoid that. However,
that turned to be wrong later. If people searchs the code from the error
or warning message, it'd better to keep it in one line, not in multiple
lines. That's the reason I merged them into one line since I have to
refactor the function. At same time, the message is shortened as "Error"
is shorter than "Failure" and "registers" in original message is meaningless.

>> + if (rc != OPAL_SUCCESS) {
>> + pr_warn("%s: Error %lld clearing error injection\n",
>> + __func__, rc);
>
>Apart from that this looks good, pending me actually testing it :)
>

Thanks :-)

Gavin

>Regards,
>Daniel
>