From: Bjorn Helgaas <helgaas@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: bhelgaas@google.com, l.stach@pengutronix.de,
linux-pci@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] PCI: imx6: Use gpio_set_value_cansleep()
Date: Wed, 25 Nov 2015 11:34:45 -0600 [thread overview]
Message-ID: <20151125173445.GF1380@localhost> (raw)
In-Reply-To: <1445989318-26461-1-git-send-email-festevam@gmail.com>
On Tue, Oct 27, 2015 at 09:41:58PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We are in a context where we can sleep, and the PCIe reset gpio may be
> on an I2C expander. Use the cansleep() variant when setting the GPIO
> value.
>
> Based on a patch from Russell King for pci-mvebu.c.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied with Lucas' Reviewed-by to pci/host-imx6 for v4.5, thanks!
> ---
> drivers/pci/host/pci-imx6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index 6f43086..e73b7f2 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -289,9 +289,9 @@ static int imx6_pcie_deassert_core_reset(struct pcie_port *pp)
>
> /* Some boards don't have PCIe reset GPIO. */
> if (gpio_is_valid(imx6_pcie->reset_gpio)) {
> - gpio_set_value(imx6_pcie->reset_gpio, 0);
> + gpio_set_value_cansleep(imx6_pcie->reset_gpio, 0);
> msleep(100);
> - gpio_set_value(imx6_pcie->reset_gpio, 1);
> + gpio_set_value_cansleep(imx6_pcie->reset_gpio, 1);
> }
> return 0;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-11-25 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 23:41 [PATCH] PCI: imx6: Use gpio_set_value_cansleep() Fabio Estevam
2015-10-28 8:47 ` Lucas Stach
2015-11-25 17:34 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125173445.GF1380@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).