linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bogicevic Sasa <brutallesale@gmail.com>
Cc: bhelgaas@google.com, wangyijing@huawei.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..."
Date: Wed, 25 Nov 2015 14:44:24 -0600	[thread overview]
Message-ID: <20151125204424.GG8869@localhost> (raw)
In-Reply-To: <1447590327-3496-1-git-send-email-brutallesale@gmail.com>

Hi Bogicevic,

On Sun, Nov 15, 2015 at 01:25:27PM +0100, Bogicevic Sasa wrote:
> This fixes all errors "space prohibited before that..." from
> checkpatch.pl

I'd take this, but I'd prefer to fix everything under drivers/pci in a
single patch, and I see several other instances of this.  I just did this
to find them:

  $ grep -r " ," drivers/pci/

Can you expand this patch to fix them all?

Thanks,
  Bjorn

> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
>  drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index d1fab97..2bac1b9 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -45,10 +45,10 @@
>  
>  #define MY_NAME	"pci_hotplug"
>  
> -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0)
> -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg)
> -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg)
> -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg)
> +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0)
> +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg)
> +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg)
> +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)
>  
>  
>  /* local variables */
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-11-25 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 12:25 [PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..." Bogicevic Sasa
2015-11-25 20:44 ` Bjorn Helgaas [this message]
2015-11-25 23:46   ` Bogicevic Sasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125204424.GG8869@localhost \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=brutallesale@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).