[PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..."

[PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..."

[Bogicevic Sasa]

This fixes all errors "space prohibited before that..." from
checkpatch.pl

Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
 drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index d1fab97..2bac1b9 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -45,10 +45,10 @@
 
 #define MY_NAME	"pci_hotplug"
 
-#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0)
-#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg)
-#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg)
-#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg)
+#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0)
+#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg)
+#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg)
+#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)
 
 
 /* local variables */
-- 
2.1.4

Re: [PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..."

[Bjorn Helgaas]

Hi Bogicevic,

On Sun, Nov 15, 2015 at 01:25:27PM +0100, Bogicevic Sasa wrote:
> This fixes all errors "space prohibited before that..." from
> checkpatch.pl

I'd take this, but I'd prefer to fix everything under drivers/pci in a
single patch, and I see several other instances of this.  I just did this
to find them:

  $ grep -r " ," drivers/pci/

Can you expand this patch to fix them all?

Thanks,
  Bjorn

> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
>  drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index d1fab97..2bac1b9 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -45,10 +45,10 @@
>  
>  #define MY_NAME	"pci_hotplug"
>  
> -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0)
> -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg)
> -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg)
> -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg)
> +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0)
> +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg)
> +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg)
> +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)
>  
>  
>  /* local variables */
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers:pci:hotplug Fix all "space prohibited before that ..."

[Bogicevic Sasa]

Sure thing, I am sending the new patch with all corrected 

Thanks, Sasa

On 11/25, Bjorn Helgaas wrote:
>Hi Bogicevic,
>
>On Sun, Nov 15, 2015 at 01:25:27PM +0100, Bogicevic Sasa wrote:
>> This fixes all errors "space prohibited before that..." from
>> checkpatch.pl
>
>I'd take this, but I'd prefer to fix everything under drivers/pci in a
>single patch, and I see several other instances of this.  I just did this
>to find them:
>
>  $ grep -r " ," drivers/pci/
>
>Can you expand this patch to fix them all?
>
>Thanks,
>  Bjorn
>
>> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
>> ---
>>  drivers/pci/hotplug/pci_hotplug_core.c | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
>> index d1fab97..2bac1b9 100644
>> --- a/drivers/pci/hotplug/pci_hotplug_core.c
>> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
>> @@ -45,10 +45,10 @@
>>
>>  #define MY_NAME	"pci_hotplug"
>>
>> -#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt , MY_NAME , __func__ , ## arg); } while (0)
>> -#define err(format, arg...) printk(KERN_ERR "%s: " format , MY_NAME , ## arg)
>> -#define info(format, arg...) printk(KERN_INFO "%s: " format , MY_NAME , ## arg)
>> -#define warn(format, arg...) printk(KERN_WARNING "%s: " format , MY_NAME , ## arg)
>> +#define dbg(fmt, arg...) do { if (debug) printk(KERN_DEBUG "%s: %s: " fmt, MY_NAME, __func__, ## arg); } while (0)
>> +#define err(format, arg...) printk(KERN_ERR "%s: " format, MY_NAME, ## arg)
>> +#define info(format, arg...) printk(KERN_INFO "%s: " format, MY_NAME, ## arg)
>> +#define warn(format, arg...) printk(KERN_WARNING "%s: " format, MY_NAME, ## arg)
>>
>>
>>  /* local variables */
>> --
>> 2.1.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html