From: Bjorn Helgaas <helgaas@kernel.org>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Lucas Stach <l.stach@pengutronix.de>,
Richard Zhu <Richard.Zhu@freescale.com>,
Jingoo Han <jingoohan1@gmail.com>
Subject: Re: [PATCH v3] PCI: imx6: Fix reset-gpio to work with active low GPIO
Date: Wed, 9 Dec 2015 09:09:35 -0600 [thread overview]
Message-ID: <20151209150935.GC31930@localhost> (raw)
In-Reply-To: <20151204210234.GH20125@localhost>
[Jingoo's response didn't make it to the list because it contained
HTML, but I incorporated it below manually]
On Tue, Dec 8, 2015 at 11:28 PM, Han Jingoo wrote:
> On Fri, Dec 04, 2015 at 03:02:34PM -0600, Bjorn Helgaas wrote:
> > [+cc Jingoo]
> >
> > On Fri, Dec 04, 2015 at 02:59:06PM -0600, Bjorn Helgaas wrote:
> > > On Fri, Nov 27, 2015 at 11:56:34AM +0100, Petr Štetiar wrote:
> > > > It's currently not possible to use reset-gpio on board where the GPIO is
> > > > active low as the code incorrectly assumes, that reset-gpio will be
> > > > always active high.
> > > >
> > > > In my case the broken behavior was observed on Toradex Apalis SoM with
> > > > Ixora base board.
> > > >
> > > > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> > >
> > > Applied as follows with Lucas' reviewed-by to pci/host-imx6 for v4.5,
> > > thanks!
> >
> > Jingoo, I noticed pci-exynos.c also uses of_get_named_gpio(). Do you
> > care about this issue, too, or are you content to ignore the GPIO
> > flags for your "reset-gpio"?
>
> Sorry, I don't care about it.
> Also, there is no issue with Exynos platform.
OK, thanks for checking!
Bjorn
prev parent reply other threads:[~2015-12-09 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 15:19 [PATCH] PCI: imx6: Fix reset-gpio to work with active low GPIO Petr Štetiar
2015-11-24 13:55 ` Lucas Stach
2015-11-27 10:01 ` [PATCH v2] " Petr Štetiar
2015-11-27 10:34 ` Lucas Stach
2015-11-27 10:56 ` [PATCH v3] " Petr Štetiar
2015-11-27 10:59 ` Lucas Stach
2015-12-04 20:59 ` Bjorn Helgaas
2015-12-04 21:02 ` Bjorn Helgaas
2015-12-09 15:09 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209150935.GC31930@localhost \
--to=helgaas@kernel.org \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).