From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:53064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbbLIPJl (ORCPT ); Wed, 9 Dec 2015 10:09:41 -0500 Date: Wed, 9 Dec 2015 09:09:35 -0600 From: Bjorn Helgaas To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Lucas Stach , Richard Zhu , Jingoo Han Subject: Re: [PATCH v3] PCI: imx6: Fix reset-gpio to work with active low GPIO Message-ID: <20151209150935.GC31930@localhost> References: <1448620464.3689.94.camel@pengutronix.de> <1448621794-19916-1-git-send-email-ynezz@true.cz> <20151204205906.GG20125@localhost> <20151204210234.GH20125@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20151204210234.GH20125@localhost> Sender: linux-pci-owner@vger.kernel.org List-ID: [Jingoo's response didn't make it to the list because it contained HTML, but I incorporated it below manually] On Tue, Dec 8, 2015 at 11:28 PM, Han Jingoo wrote: > On Fri, Dec 04, 2015 at 03:02:34PM -0600, Bjorn Helgaas wrote: > > [+cc Jingoo] > > > > On Fri, Dec 04, 2015 at 02:59:06PM -0600, Bjorn Helgaas wrote: > > > On Fri, Nov 27, 2015 at 11:56:34AM +0100, Petr Štetiar wrote: > > > > It's currently not possible to use reset-gpio on board where the GPIO is > > > > active low as the code incorrectly assumes, that reset-gpio will be > > > > always active high. > > > > > > > > In my case the broken behavior was observed on Toradex Apalis SoM with > > > > Ixora base board. > > > > > > > > Signed-off-by: Petr Štetiar > > > > > > Applied as follows with Lucas' reviewed-by to pci/host-imx6 for v4.5, > > > thanks! > > > > Jingoo, I noticed pci-exynos.c also uses of_get_named_gpio(). Do you > > care about this issue, too, or are you content to ignore the GPIO > > flags for your "reset-gpio"? > > Sorry, I don't care about it. > Also, there is no issue with Exynos platform. OK, thanks for checking! Bjorn