* [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express
@ 2016-01-04 16:47 Tim Sander
2016-01-08 20:49 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Tim Sander @ 2016-01-04 16:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Bjorn Helgaas, linux-pci
Hi
Please consider this patch for the next release. It won't recognize my Plextor
M6e PCIE disk without it. Please cc as i am not on the list.
Signed-off-by: Tim Sander <tim@krieglstein.org>
PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
---
drivers/pci/quirks.c | 4 ++++
include/linux/pci_ids.h | 3 +++
2 files changed, 7 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 7e32730..93ec5a02 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
PCI_DEVICE_ID_JMICRON_JMB388_ESD,
quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
+ PCI_DEVICE_ID_PLEXTOR_M6E,
+ quirk_dma_func1_alias);
/*
* Some devices DMA with the wrong devfn, not just the wrong function.
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index d9ba49c..01d8041 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2501,6 +2501,9 @@
#define PCI_VENDOR_ID_ASMEDIA 0x1b21
+#define PCI_VENDOR_ID_LITE_ON 0x1c28
+#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122
+
#define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
#define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express
2016-01-04 16:47 [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Tim Sander
@ 2016-01-08 20:49 ` Bjorn Helgaas
2016-01-08 21:15 ` Alex Williamson
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2016-01-08 20:49 UTC (permalink / raw)
To: Tim Sander; +Cc: linux-kernel, Bjorn Helgaas, linux-pci, Alex Williamson
[+cc Alex]
On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote:
> Hi
>
> Please consider this patch for the next release. It won't recognize my Plextor
> M6e PCIE disk without it. Please cc as i am not on the list.
>
> Signed-off-by: Tim Sander <tim@krieglstein.org>
>
> PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14)
Alex?
Please use a subject line that matches the other similar commits:
247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120
c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint RocketRaid 642L
cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell devices
> ---
> drivers/pci/quirks.c | 4 ++++
> include/linux/pci_ids.h | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7e32730..93ec5a02 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> quirk_dma_func1_alias);
> +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
Thanks for the link. There are 126 comments on that bugzilla so far,
so it'd be nice to have a more specific pointer. I'm guessing 117
might be the relevant one, so:
https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> + PCI_DEVICE_ID_PLEXTOR_M6E,
> + quirk_dma_func1_alias);
>
> /*
> * Some devices DMA with the wrong devfn, not just the wrong function.
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index d9ba49c..01d8041 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2501,6 +2501,9 @@
>
> #define PCI_VENDOR_ID_ASMEDIA 0x1b21
>
> +#define PCI_VENDOR_ID_LITE_ON 0x1c28
> +#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122
Since these constants are only used in one place, don't add them to
pci_ids.h (see comment at the top of this file). Just use the hex
constants directly in the quirk and include the vendor/device names in
the comment.
> #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
> #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
>
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express
2016-01-08 20:49 ` Bjorn Helgaas
@ 2016-01-08 21:15 ` Alex Williamson
2016-01-15 12:30 ` [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183 Tim Sander
0 siblings, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2016-01-08 21:15 UTC (permalink / raw)
To: Bjorn Helgaas, Tim Sander; +Cc: linux-kernel, Bjorn Helgaas, linux-pci
On Fri, 2016-01-08 at 14:49 -0600, Bjorn Helgaas wrote:
> [+cc Alex]
>
> On Mon, Jan 04, 2016 at 05:47:14PM +0100, Tim Sander wrote:
> > Hi
> >
> > Please consider this patch for the next release. It won't recognize
> > my Plextor
> > M6e PCIE disk without it. Please cc as i am not on the list.
> >
> > Signed-off-by: Tim Sander <tim@krieglstein.org>
> >
> > PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express SSD
> > [Marvell 88SS9183] (rev 14)
>
> Alex?
Aside from the style issues you've already commented on, I'll give a
thumbs up to quirking this device. Thanks,
Alex
> Please use a subject line that matches the other similar commits:
>
> 247de694349c PCI: Add function 1 DMA alias quirk for Marvell 9120
> c2e0fb966ad8 PCI: Add function 1 DMA alias quirk for HighPoint
> RocketRaid 642L
> cc346a4714a5 PCI: Add function 1 DMA alias quirk for Marvell
> devices
>
> > ---
> > drivers/pci/quirks.c | 4 ++++
> > include/linux/pci_ids.h | 3 +++
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 7e32730..93ec5a02 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI,
> > 0x0642,
> > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> > PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> > quirk_dma_func1_alias);
> > +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679 */
>
> Thanks for the link. There are 126 comments on that bugzilla so far,
> so it'd be nice to have a more specific pointer. I'm guessing 117
> might be the relevant one, so:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117
>
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LITE_ON,
> > + PCI_DEVICE_ID_PLEXTOR_M6E,
> > + quirk_dma_func1_alias);
> >
> > /*
> > * Some devices DMA with the wrong devfn, not just the wrong
> > function.
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index d9ba49c..01d8041 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2501,6 +2501,9 @@
> >
> > #define PCI_VENDOR_ID_ASMEDIA 0x1b21
> >
> > +#define PCI_VENDOR_ID_LITE_ON 0x1c28
> > +#define PCI_DEVICE_ID_PLEXTOR_M6E 0x0122
>
> Since these constants are only used in one place, don't add them to
> pci_ids.h (see comment at the top of this file). Just use the hex
> constants directly in the quirk and include the vendor/device names
> in
> the comment.
>
> > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
> > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183
2016-01-08 21:15 ` Alex Williamson
@ 2016-01-15 12:30 ` Tim Sander
2016-01-15 17:03 ` Alex Williamson
2016-01-19 20:37 ` Bjorn Helgaas
0 siblings, 2 replies; 6+ messages in thread
From: Tim Sander @ 2016-01-15 12:30 UTC (permalink / raw)
To: Alex Williamson, linux-pci; +Cc: Bjorn Helgaas, linux-kernel
Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183
Signed-off-by: Tim Sander <tim@krieglstein.org>
---
drivers/pci/quirks.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 7e32730..40b1dfe 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
PCI_DEVICE_ID_JMICRON_JMB388_ESD,
quirk_dma_func1_alias);
+/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
+DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
+ 0x0122, /* Plextor M6E (Marvell 88SS9183)*/
+ quirk_dma_func1_alias);
/*
* Some devices DMA with the wrong devfn, not just the wrong function.
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183
2016-01-15 12:30 ` [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183 Tim Sander
@ 2016-01-15 17:03 ` Alex Williamson
2016-01-19 20:37 ` Bjorn Helgaas
1 sibling, 0 replies; 6+ messages in thread
From: Alex Williamson @ 2016-01-15 17:03 UTC (permalink / raw)
To: Tim Sander, linux-pci; +Cc: Bjorn Helgaas, linux-kernel
On Fri, 2016-01-15 at 13:30 +0100, Tim Sander wrote:
> Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell
> 88SS9183
>
> Signed-off-by: Tim Sander <tim@krieglstein.org>
> ---
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> drivers/pci/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7e32730..40b1dfe 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI,
> 0x0642,
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> quirk_dma_func1_alias);
> +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
> +DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
> + 0x0122, /* Plextor M6E (Marvell 88SS9183)*/
> + quirk_dma_func1_alias);
>
> /*
> * Some devices DMA with the wrong devfn, not just the wrong
> function.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183
2016-01-15 12:30 ` [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183 Tim Sander
2016-01-15 17:03 ` Alex Williamson
@ 2016-01-19 20:37 ` Bjorn Helgaas
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2016-01-19 20:37 UTC (permalink / raw)
To: Tim Sander; +Cc: Alex Williamson, linux-pci, linux-kernel
On Fri, Jan 15, 2016 at 01:30:58PM +0100, Tim Sander wrote:
> Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183
>
> Signed-off-by: Tim Sander <tim@krieglstein.org>
Applied with Alex's ack to pci/iommu for v4.5, thanks!
> ---
> drivers/pci/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 7e32730..40b1dfe 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3620,6 +3620,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_JMICRON,
> PCI_DEVICE_ID_JMICRON_JMB388_ESD,
> quirk_dma_func1_alias);
> +/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c117 */
> +DECLARE_PCI_FIXUP_HEADER(0x1c28, /* Lite-On */
> + 0x0122, /* Plextor M6E (Marvell 88SS9183)*/
> + quirk_dma_func1_alias);
>
> /*
> * Some devices DMA with the wrong devfn, not just the wrong function.
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-19 20:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 16:47 [PATCH] PCI: Add quirk for Lite-On IT Corp. / Plextor M6e PCI Express Tim Sander
2016-01-08 20:49 ` Bjorn Helgaas
2016-01-08 21:15 ` Alex Williamson
2016-01-15 12:30 ` [PATCH] PCI: Add function 1 DMA alias quirk for Lite-On/Plextor M6e/Marvell 88SS9183 Tim Sander
2016-01-15 17:03 ` Alex Williamson
2016-01-19 20:37 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).