From: Bjorn Helgaas <helgaas@kernel.org>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: bhelgaas@google.com, jingoohan1@gmail.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: designware: Remove unused variable
Date: Mon, 11 Jan 2016 08:43:23 -0600 [thread overview]
Message-ID: <20160111144323.GB25540@localhost> (raw)
In-Reply-To: <1452512470-20890-1-git-send-email-fabio.estevam@nxp.com>
On Mon, Jan 11, 2016 at 09:41:10AM -0200, Fabio Estevam wrote:
> Commit 50a1a3b06dddaa5b ("PCI: designware: Simplify control flow")
> causes the following build warning:
>
> drivers/pci/host/pcie-designware.c:683:6: warning: unused variable 'ret' [-Wunused-variable]
>
> Remove the unused 'ret' varaible.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Thanks guys, sorry about this oversight. I folded this into the original
patch.
> ---
> drivers/pci/host/pcie-designware.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 9a666db..2171682 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -680,7 +680,6 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,
> int where, int size, u32 val)
> {
> struct pcie_port *pp = bus->sysdata;
> - int ret;
>
> if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0)
> return PCIBIOS_DEVICE_NOT_FOUND;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-11 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 11:41 [PATCH] PCI: designware: Remove unused variable Fabio Estevam
2016-01-11 14:43 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-11 12:11 [PATCH] PCI: designware: remove " Arnd Bergmann
2016-01-11 12:15 [PATCH] PCI: designware: Remove " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111144323.GB25540@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).