From: Bjorn Helgaas <helgaas@kernel.org>
To: "Lawrynowicz, Jacek" <jacek.lawrynowicz@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jroedel@suse.de" <jroedel@suse.de>
Subject: Re: [PATCH v2 1/2] pci: Add support for multiple DMA aliases
Date: Tue, 26 Jan 2016 08:34:18 -0600 [thread overview]
Message-ID: <20160126143418.GA9279@localhost> (raw)
In-Reply-To: <36D38C1F74839847A52A484C31F3E51A6213B1EF@irsmsx105.ger.corp.intel.com>
On Tue, Jan 26, 2016 at 12:04:47PM +0000, Lawrynowicz, Jacek wrote:
> > -----Original Message-----
> > From: David Woodhouse [mailto:dwmw2@infradead.org]
> > Sent: Tuesday, January 26, 2016 12:59 PM
> > To: Lawrynowicz, Jacek <jacek.lawrynowicz@intel.com>; linux-
> > pci@vger.kernel.org
> > Cc: bhelgaas@google.com; alex.williamson@redhat.com; jroedel@suse.de
> > Subject: Re: [PATCH v2 1/2] pci: Add support for multiple DMA aliases
> >
> > On Tue, 2016-01-26 at 11:31 +0100, Jacek Lawrynowicz wrote:
> > >
> > > +bool pci_dma_alias_is_enabled(struct pci_dev *dev, u8 devfn)
> > > +{
> > > + return dev->dma_alias_mask &&
> > > + test_bit(devfn, dev->dma_alias_mask);
> > > +}
> > > +EXPORT_SYMBOL_GPL(pci_dma_alias_is_enabled);
> >
> > Why export this?
>
> So it can be used in drivers/iommu/iommu.c in get_pci_alias_group().
> Bjorn didn't want dma_alias_mask to be used there directly.
Declaring pci_dma_alias_is_enabled() in include/linux/pci.h is
sufficient to allow drivers/iommu/iommu.c to use it. The
EXPORT_SYMBOL_GPL() is not needed.
Bjorn
next prev parent reply other threads:[~2016-01-26 14:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 10:31 [PATCH v2 1/2] pci: Add support for multiple DMA aliases Jacek Lawrynowicz
2016-01-26 10:31 ` [PATCH v2 2/2] pci: Add DMA alias quirk for mic_x200_dma Jacek Lawrynowicz
2016-01-26 16:28 ` Alex Williamson
2016-01-26 17:20 ` Lawrynowicz, Jacek
2016-01-26 17:24 ` Jacek Lawrynowicz
2016-01-26 11:59 ` [PATCH v2 1/2] pci: Add support for multiple DMA aliases David Woodhouse
2016-01-26 12:04 ` Lawrynowicz, Jacek
2016-01-26 12:27 ` David Woodhouse
2016-01-26 14:34 ` Bjorn Helgaas [this message]
2016-01-26 14:52 ` Jacek Lawrynowicz
2016-01-26 15:07 ` David Woodhouse
2016-01-26 16:27 ` Alex Williamson
2016-01-26 17:12 ` Jacek Lawrynowicz
2016-01-26 23:31 ` Bjorn Helgaas
2016-01-26 23:42 ` Alex Williamson
2016-01-27 0:04 ` Bjorn Helgaas
2016-01-27 0:54 ` Alex Williamson
2016-01-27 20:05 ` Lawrynowicz, Jacek
2016-01-27 20:25 ` Alex Williamson
2016-01-30 11:06 ` [PATCH v3 0/2] Fixed couple of issues pointed by Alex and Bjorn Jacek Lawrynowicz
2016-01-30 11:06 ` [PATCH v3 1/2] pci: Add support for multiple DMA aliases Jacek Lawrynowicz
2016-02-15 17:22 ` Joerg Roedel
2016-01-30 11:06 ` [PATCH v3 2/2] pci: Add DMA alias quirk for mic_x200_dma Jacek Lawrynowicz
2016-01-27 20:01 ` [PATCH v2 1/2] pci: Add support for multiple DMA aliases Lawrynowicz, Jacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126143418.GA9279@localhost \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=jacek.lawrynowicz@intel.com \
--cc=jroedel@suse.de \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).