From: Bjorn Helgaas <helgaas@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Borislav Petkov <bp@suse.de>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
john.ronciak@intel.com, tony.luck@intel.com,
Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] PCI: aer_inject: Log actual error causes
Date: Tue, 26 Jan 2016 16:16:14 -0600 [thread overview]
Message-ID: <20160126221614.GB26726@localhost> (raw)
In-Reply-To: <1453813554.4772.131.camel@chaos.site>
On Tue, Jan 26, 2016 at 02:05:54PM +0100, Jean Delvare wrote:
> Le Tuesday 26 January 2016 à 13:49 +0100, Borislav Petkov a écrit :
> > On Tue, Jan 26, 2016 at 01:27:18PM +0100, Jean Delvare wrote:
> > > But I'd say -EPERM is hardly better. The problem with -ENODEV is that it
> > > is already returned by this function for several other error causes.
> > > Also the aer-inject user-space tool will print the error message from
> > > the error code, and I don't think "No such device" is helpful in that
> > > case. What about -ENOTSUPP ("Operation not supported") or
> > > -EEPROTONOSUPPORT ("Protocol not supported")?
> >
> > Makes sense.
> >
> > > I can change it if nobody objects. I think the change can be included in
> > > this patch as it is quite related.
> >
> > I'd do a separate patch but this is only my opinion. I guess that's
> > Bjorn's call.
>
> I am almost always advocating for separate patches, but here it seemed
> like hairsplitting so I wasn't sure. I'm fine both ways really.
I'd prefer one patch to change the errno (only) and another to add the
printk logging.
I definitely prefer dev_* whenever possible. The aer_inject user
knows the relevant device at the time, but dev_* makes the dmesg log
more useful later.
In fact, your patch only adds logging to some error paths. I'd like
to have some indication in dmesg that aer_inject was used at all.
Maybe even a synopsis of the injected error, though maybe that's too
much if aer_inject is used in an automated way. It would just be nice
to have a dmesg indication that subsequent AER events *might* be
injected rather than real errors.
Bjorn
prev parent reply other threads:[~2016-01-26 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 8:52 [PATCH] PCI: aer_inject: Log actual error causes Jean Delvare
2016-01-26 10:12 ` Borislav Petkov
2016-01-26 12:27 ` Jean Delvare
2016-01-26 12:49 ` Borislav Petkov
2016-01-26 13:05 ` Jean Delvare
2016-01-26 22:16 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126221614.GB26726@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=jdelvare@suse.de \
--cc=john.ronciak@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).