From: Bjorn Helgaas <helgaas@kernel.org>
To: Kelly Zytaruk <kelly.zytaruk@amd.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH] PCI: Support SRIOV on Legacy EndPoint device
Date: Thu, 4 Feb 2016 09:14:25 -0600 [thread overview]
Message-ID: <20160204151425.GA27474@localhost> (raw)
In-Reply-To: <1454597306-26189-1-git-send-email-kelly.zytaruk@amd.com>
[+cc Alex, Yu (participants in previous discussion)]
Hi Kelly,
On Thu, Feb 04, 2016 at 09:48:26AM -0500, Kelly Zytaruk wrote:
> Some AMD GPUs have hardware support for grapics SRIOV.
> If the GPU has a display output then the GPU needs to support Legacy VGA operation.
> If CLASS_CODE = VGA then the device should have a Port Type = Legacy EndPoint.
> Therefore in order to enable SRIOV on a GPU with a display output LEGACY_END_POINT is supported as a valid Port Type.
>
> Signed-off-by: Kelly Zytaruk <kelly.zytaruk@amd.com>
We had an interesting discussion about this two years ago:
http://lkml.kernel.org/r/B756807489D6244883AC0B799A6EEC15EAB2E8@storexdag02.amd.com
Please include a reference to that discussion in your changelog. In that
discussion, I also asked for some details (dmesg and lspci info) that
motivate the change, so please collect and add a reference to them as well.
It's not clear to me why we check the device type at all. If there's no
spec restriction on the types of devices that can have an SR-IOV
capability, we should consider removing the test altogether (Alex mentioned
this possiblity in the earlier discussion).
Bjorn
> ---
> drivers/pci/iov.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 31f31d4..da4fbac 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -388,7 +388,8 @@ static int sriov_init(struct pci_dev *dev, int pos)
> struct pci_dev *pdev;
>
> if (pci_pcie_type(dev) != PCI_EXP_TYPE_RC_END &&
> - pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT)
> + pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT &&
> + pci_pcie_type(dev) != PCI_EXP_TYPE_LEG_END)
> return -ENODEV;
>
> pci_read_config_word(dev, pos + PCI_SRIOV_CTRL, &ctrl);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-04 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 14:48 [PATCH] PCI: Support SRIOV on Legacy EndPoint device Kelly Zytaruk
2016-02-04 15:14 ` Bjorn Helgaas [this message]
2016-02-04 16:21 ` Zytaruk, Kelly
2016-02-05 16:46 ` Bjorn Helgaas
2016-02-05 16:50 ` Zytaruk, Kelly
2016-02-05 16:59 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2016-02-04 15:08 Zytaruk, Kelly
2016-02-09 18:08 kelly.zytaruk
2016-02-29 18:00 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204151425.GA27474@localhost \
--to=helgaas@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=kelly.zytaruk@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).