From: Lee Jones <lee.jones@linaro.org>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Richard Zhu <Richard.Zhu@freescale.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: imx6sx: Add PCIe register definitions for iomuxc gpr
Date: Mon, 15 Feb 2016 08:19:34 +0000 [thread overview]
Message-ID: <20160215081934.GA3455@x1> (raw)
In-Reply-To: <1455483164-13755-2-git-send-email-chf.fritz@googlemail.com>
The subject line is wrong. It's not an ARM patch, but an MFD one.
On Sun, 14 Feb 2016, Christoph Fritz wrote:
> This patch adds macros to define masks and bits for imx6sx
> PCIe registers. This is based on a patch by Richard Zhu.
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> ---
> include/linux/mfd/syscon/imx6q-iomuxc-gpr.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h b/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h
> index 558a485..93d859b 100644
> --- a/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h
> +++ b/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h
> @@ -422,6 +422,12 @@
> #define IMX6SX_GPR5_VADC_TO_CSI_CAPTURE_EN_MASK (0x1 << 26)
> #define IMX6SX_GPR5_VADC_TO_CSI_CAPTURE_EN_ENABLE (0x1 << 26)
> #define IMX6SX_GPR5_VADC_TO_CSI_CAPTURE_EN_DISABLE (0x0 << 26)
> +#define IMX6SX_GPR5_PCIE_BTNRST_MASK (0x1 << 19)
All of these (1 << x) should be BIT(x).
> +#define IMX6SX_GPR5_PCIE_BTNRST_RESET (0x1 << 19)
> +#define IMX6SX_GPR5_PCIE_BTNRST_RELEASE (0x0 << 19)
There is no need for all these (0 << x) entries.
(0 << x) is always 0.
> +#define IMX6SX_GPR5_PCIE_PERST_MASK (0x1 << 18)
> +#define IMX6SX_GPR5_PCIE_PERST_RESET (0x1 << 18)
> +#define IMX6SX_GPR5_PCIE_PERST_RELEASE (0x0 << 18)
> #define IMX6SX_GPR5_CSI1_MUX_CTRL_MASK (0x3 << 4)
> #define IMX6SX_GPR5_CSI1_MUX_CTRL_EXT_PIN (0x0 << 4)
> #define IMX6SX_GPR5_CSI1_MUX_CTRL_CVD (0x1 << 4)
> @@ -435,6 +441,15 @@
> #define IMX6SX_GPR5_DISP_MUX_DCIC1_LVDS (0x1 << 1)
> #define IMX6SX_GPR5_DISP_MUX_DCIC1_MASK (0x1 << 1)
>
> +#define IMX6SX_GPR12_PCIE_TEST_POWERDOWN_MASK (0x1 << 30)
> +#define IMX6SX_GPR12_PCIE_TEST_POWERDOWN_ENABLE (0x1 << 30)
> +#define IMX6SX_GPR12_PCIE_TEST_POWERDOWN_DISABLE (0x0 << 30)
> +#define IMX6SX_GPR12_PCIE_PM_TURNOFF_MASK (0x1 << 16)
> +#define IMX6SX_GPR12_PCIE_PM_TURNOFF_OFF (0x1 << 16)
> +#define IMX6SX_GPR12_PCIE_PM_TURNOFF_RELEASE (0x0 << 16)
> +#define IMX6SX_GPR12_PCIE_RX_EQ_MASK (0x7 << 0)
> +#define IMX6SX_GPR12_PCIE_RX_EQ_2 (0x2 << 0)
> +
> /* For imx6ul iomux gpr register field define */
> #define IMX6UL_GPR1_ENET1_CLK_DIR (0x1 << 17)
> #define IMX6UL_GPR1_ENET2_CLK_DIR (0x1 << 18)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-02-15 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 20:52 [PATCH 0/2] ARM: imx6sx - add initial PCIe support Christoph Fritz
2016-02-14 20:52 ` [PATCH 1/2] ARM: imx6sx: Add PCIe register definitions for iomuxc gpr Christoph Fritz
2016-02-15 8:19 ` Lee Jones [this message]
2016-02-14 20:52 ` [PATCH 2/2] PCI: imx6: add initial imx6sx support Christoph Fritz
2016-02-15 7:24 ` Richard Zhu
2016-02-18 11:59 ` Christoph Fritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215081934.GA3455@x1 \
--to=lee.jones@linaro.org \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=chf.fritz@googlemail.com \
--cc=fabio.estevam@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).