From: Jean Delvare <jdelvare@suse.de>
To: linux-pci@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>,
Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@suse.de>,
Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH 2/4] PCI: aer_inject: Use dev_warn()
Date: Thu, 18 Feb 2016 13:52:01 +0100 [thread overview]
Message-ID: <20160218135201.1a97a532@endymion> (raw)
In-Reply-To: <20160218130928.67dbf63b@endymion>
dev_warn() is better than printk(LOG_WARNING...) as it records which
device the message relates to. Also add a prefix "aer_inject:" to
help differentiate real errors from injected errors.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pcie/aer/aer_inject.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- linux-4.5-rc4.orig/drivers/pci/pcie/aer/aer_inject.c 2016-02-18 11:41:48.738010173 +0100
+++ linux-4.5-rc4/drivers/pci/pcie/aer/aer_inject.c 2016-02-18 12:50:56.927581343 +0100
@@ -25,6 +25,7 @@
#include <linux/fs.h>
#include <linux/uaccess.h>
#include <linux/stddef.h>
+#include <linux/device.h>
#include "aerdrv.h"
/* Override the existing corrected and uncorrected error masks */
@@ -397,14 +398,16 @@ static int aer_inject(struct aer_error_i
if (!aer_mask_override && einj->cor_status &&
!(einj->cor_status & ~cor_mask)) {
ret = -EINVAL;
- printk(KERN_WARNING "The correctable error(s) is masked by device\n");
+ dev_warn(&dev->dev,
+ "aer_inject: The correctable error(s) is masked by device\n");
spin_unlock_irqrestore(&inject_lock, flags);
goto out_put;
}
if (!aer_mask_override && einj->uncor_status &&
!(einj->uncor_status & ~uncor_mask)) {
ret = -EINVAL;
- printk(KERN_WARNING "The uncorrectable error(s) is masked by device\n");
+ dev_warn(&dev->dev,
+ "aer_inject: The uncorrectable error(s) is masked by device\n");
spin_unlock_irqrestore(&inject_lock, flags);
goto out_put;
}
@@ -457,7 +460,8 @@ static int aer_inject(struct aer_error_i
if (find_aer_device(rpdev, &edev)) {
if (!get_service_data(edev)) {
- printk(KERN_WARNING "AER service is not initialized\n");
+ dev_warn(&edev->device,
+ "aer_inject: AER service is not initialized\n");
ret = -EPROTONOSUPPORT;
goto out_put;
}
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-02-18 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 12:09 [PATCH 0/4] PCI: aer_inject cleanups and verbosity Jean Delvare
2016-02-18 12:50 ` [PATCH 1/4] PCI: aer_inject: Fix error codes Jean Delvare
2016-02-18 12:52 ` Jean Delvare [this message]
2016-02-18 12:52 ` [PATCH 3/4] PCI: aer_inject: Log actual error causes Jean Delvare
2016-02-18 12:54 ` [PATCH 4/4] PCI: aer_inject: Log error injections Jean Delvare
2016-03-08 21:53 ` [PATCH 0/4] PCI: aer_inject cleanups and verbosity Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218135201.1a97a532@endymion \
--to=jdelvare@suse.de \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=linux-pci@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).