linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: linux-pci@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>,
	Bjorn Helgaas <bhelgaas@google.com>, Borislav Petkov <bp@suse.de>,
	Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH 4/4]  PCI: aer_inject: Log error injections
Date: Thu, 18 Feb 2016 13:54:02 +0100	[thread overview]
Message-ID: <20160218135402.61061d5a@endymion> (raw)
In-Reply-To: <20160218130928.67dbf63b@endymion>

Log successful error injections so that injected errors can be
differentiated from real errors.

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
Note: none of my systems support AER injection so this is untested.

 drivers/pci/pcie/aer/aer_inject.c |    3 +++
 1 file changed, 3 insertions(+)

--- linux-4.5-rc4.orig/drivers/pci/pcie/aer/aer_inject.c	2016-02-18 13:20:02.063933626 +0100
+++ linux-4.5-rc4/drivers/pci/pcie/aer/aer_inject.c	2016-02-18 13:20:02.515936151 +0100
@@ -469,6 +469,9 @@ static int aer_inject(struct aer_error_i
 			ret = -EPROTONOSUPPORT;
 			goto out_put;
 		}
+		dev_info(&edev->device,
+			 "aer_inject: Injecting errors %08x/%08x into device %s\n",
+			 einj->cor_status, einj->uncor_status, pci_name(dev));
 		aer_irq(-1, edev);
 	} else {
 		dev_err(&rpdev->dev, "aer_inject: AER device not found\n");

-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2016-02-18 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 12:09 [PATCH 0/4] PCI: aer_inject cleanups and verbosity Jean Delvare
2016-02-18 12:50 ` [PATCH 1/4] PCI: aer_inject: Fix error codes Jean Delvare
2016-02-18 12:52 ` [PATCH 2/4] PCI: aer_inject: Use dev_warn() Jean Delvare
2016-02-18 12:52 ` [PATCH 3/4] PCI: aer_inject: Log actual error causes Jean Delvare
2016-02-18 12:54 ` Jean Delvare [this message]
2016-03-08 21:53 ` [PATCH 0/4] PCI: aer_inject cleanups and verbosity Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218135402.61061d5a@endymion \
    --to=jdelvare@suse.de \
    --cc=bhelgaas@google.com \
    --cc=bp@suse.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).