[PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

This driver uses PCI glue that is only available on 32-bit ARM. This
used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
32-bit, but that's changed now, with ARCH_MVEBU also being available
on 64-bit ARM.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/pci/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 75a605426538..d1cdd9c992ac 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -14,6 +14,7 @@ config PCI_DRA7XX
 config PCI_MVEBU
 	bool "Marvell EBU PCIe controller"
 	depends on ARCH_MVEBU || ARCH_DOVE
+	depends on ARM
 	depends on OF
 
 config PCIE_DW
-- 
2.7.1

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Arnd Bergmann]

On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Looks fine as a temporary workaround, but I think what we really want to
do here is to remove the dependency, as the new ARM64 platforms are going
to need this driver anyway.

	Arnd

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Thu, Feb 18, 2016 at 03:06:23PM +0100, Arnd Bergmann wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > This driver uses PCI glue that is only available on 32-bit ARM. This
> > used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> > 32-bit, but that's changed now, with ARCH_MVEBU also being available
> > on 64-bit ARM.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.

Agreed. I've been meaning to do just that for Tegra as well, but the
conversion is somewhat more involved and this is currently breaking the
linux-next builds, so a quick fix, even if temporary, is warranted in my
opinion.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Thomas Petazzoni]

Hello,

On Thu, 18 Feb 2016 14:32:10 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Gregory CLEMENT]

Hi Arnd,
 
 On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:

> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>> 
>> This driver uses PCI glue that is only available on 32-bit ARM. This
>> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
>> 32-bit, but that's changed now, with ARCH_MVEBU also being available
>> on 64-bit ARM.
>> 
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.

Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
8K), won't use the same controller. A7K/A8K will use a synopsis IP and
Armada 3700 a new Marvell IP.

So for me depending on ARM32 is enough.

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Arnd Bergmann]

On Thursday 18 February 2016 15:34:30 Gregory CLEMENT wrote:
>  On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >> 
> >> This driver uses PCI glue that is only available on 32-bit ARM. This
> >> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> >> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> >> on 64-bit ARM.
> >> 
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Looks fine as a temporary workaround, but I think what we really want to
> > do here is to remove the dependency, as the new ARM64 platforms are going
> > to need this driver anyway.
> 
> Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
> 8K), won't use the same controller. A7K/A8K will use a synopsis IP and
> Armada 3700 a new Marvell IP.
> 
> So for me depending on ARM32 is enough.

Ah, that makes things much easier indeed.

Does this mean no more MBUS on the 64-bit platforms too?

	Arnd

Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

[Bjorn Helgaas]

On Thu, Feb 18, 2016 at 02:32:10PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

I applied this with Thomas' ack to my for-linus branch for v4.5, thanks
Thierry!

> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 75a605426538..d1cdd9c992ac 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -14,6 +14,7 @@ config PCI_DRA7XX
>  config PCI_MVEBU
>  	bool "Marvell EBU PCIe controller"
>  	depends on ARCH_MVEBU || ARCH_DOVE
> +	depends on ARM
>  	depends on OF
>  
>  config PCIE_DW
> -- 
> 2.7.1
>