From: Jon Derrick <jonathan.derrick@intel.com>
To: Keith Busch <keith.busch@intel.com>
Cc: helgaas@kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
bryan.e.veal@intel.com, linux-pci@vger.kernel.org,
tglx@linutronix.de, dan.j.williams@intel.com
Subject: Re: [PATCH] VMD: Attach vmd resources to parent domain's resource tree
Date: Tue, 23 Feb 2016 16:47:10 -0700 [thread overview]
Message-ID: <20160223234710.GA8670@localhost.localdomain> (raw)
In-Reply-To: <20160223231610.GC20250@localhost.localdomain>
On Tue, Feb 23, 2016 at 11:16:11PM +0000, Keith Busch wrote:
> On Tue, Feb 23, 2016 at 02:50:13PM -0700, Jon Derrick wrote:
> > This patch attaches the new VMD domain's resources to the VMD device's
> > resources. This allows /proc/iomem to display a more complete picture.
> >
> > Before:
> > c0000000-c1ffffff : 0000:5d:05.5
> > c2000000-c3ffffff : 0000:5d:05.5
> > c2010000-c2013fff : nvme
> > c4000000-c40fffff : 0000:5d:05.5
> >
> > After:
> > c0000000-c1ffffff : 0000:5d:05.5
> > c0000000-0000001f : VMD CFGBAR
> > c2000000-c3ffffff : 0000:5d:05.5
> > c2000000-c3ffffff : VMD MEMBAR1
> > c2000000-c22fffff : PCI Bus 10000:01
> > c2000000-c200ffff : 10000:01:00.0
> > c2010000-c2013fff : 10000:01:00.0
> > c2010000-c2013fff : nvme
> > c2300000-c24fffff : PCI Bus 10000:01
> > c4000000-c40fffff : 0000:5d:05.5
> > c4002000-c40fffff : VMD MEMBAR2
>
> I think we should drop the CFGBAR from here since that's a bus resource
> rather than IO memory. Otherwise, this looks good and useful.
Yes that entry doesn't make much sense for iomem does it. I'll drop that part.
>
> I think in the near future we should come up with a better name than
> "VMD MEMBAR" to help distinguish multiple VMD's in a system.
Seconded. I'm fine with naming it by its PCI designator, eg 10000:01:00.0, and maybe a bar designator after that (or not).
prev parent reply other threads:[~2016-02-23 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 21:50 [PATCH] VMD: Attach vmd resources to parent domain's resource tree Jon Derrick
2016-02-23 23:16 ` Keith Busch
2016-02-23 23:47 ` Jon Derrick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223234710.GA8670@localhost.localdomain \
--to=jonathan.derrick@intel.com \
--cc=bryan.e.veal@intel.com \
--cc=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).