From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:46394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932158AbcCDQ1l (ORCPT ); Fri, 4 Mar 2016 11:27:41 -0500 Date: Fri, 4 Mar 2016 10:27:37 -0600 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel Subject: Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM Message-ID: <20160304162737.GA1296@localhost> References: <20160303173522.GA9189@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-ID: On Fri, Mar 04, 2016 at 07:13:49AM +0100, Krzysztof Hałasa wrote: > Hi Bjorn, > > Bjorn Helgaas writes: > > > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote: > >> Many ARM platforms use a wrapper: > >> /* > >> * Compatibility wrapper for older platforms that do not care about > >> * passing the parent device. > >> */ > >> static inline void pci_common_init(struct hw_pci *hw) > >> { > >> pci_common_init_dev(NULL, hw); > >> } > >> > >> which means that pci_bus_assign_domain_nr() can be called without > >> a parent. This patch fixes the NULL pointer dereference. > > > > What exactly is the impact of this? Does this fix need to be in v4.5? > > It sounds like it should be, but I need a little more detailed > > justification, e.g., "platforms X, Y, Z don't boot at all without > > this change." > > At least CNS3xxx doesn't boot. I haven't verified a couple of others, > but they may be broken as well. Good, thanks. Also (I should have asked this before), please include a "Fixes:" line so we know exactly when this broke and what stable kernels need the fix. Bjorn