linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Andi Kleen <ak@linux.intel.com>,
	Jayachandran Chandrashekaran Nair
	<jayachandran.chandrashekaran@broadcom.com>,
	Rob Herring <robh@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v1 0/3] PCI: Avoid touching non-compliant BARs
Date: Tue, 8 Mar 2016 11:50:20 -0600	[thread overview]
Message-ID: <20160308175020.GD19869@localhost> (raw)
In-Reply-To: <20160226155334.9113.77645.stgit@bhelgaas-glaptop2.roam.corp.google.com>

On Fri, Feb 26, 2016 at 09:58:42AM -0600, Bjorn Helgaas wrote:
> Hi guys,
> 
> Here's a proposal for dealing with these devices that have non-BAR
> registers where BARs are supposed to be.  The idea is to:
> 
>   - have an early quirk mark these devices,
>   - disable IO & MEM decoding so the devices don't consume address space
>     we don't know about, and
>   - skip BAR sizing (so the struct resources stay zeroed out)
> 
> This is basically a modification of what Andi originally proposed.  The
> difference here is that we never touch the BAR at all, and we don't have to
> add any struct resource flags, so we don't have to worry about changing any
> consumers of the struct resources.
> 
> Let me know what you think.
> 
> ---
> 
> Bjorn Helgaas (3):
>       PCI: Disable IO/MEM decoding for devices with non-compliant BARs
>       x86/PCI: Mark Broadwell-EP Home Agent & PCU as having non-compliant BARs
>       PCI: Mark Broadcom Vulcan bridges as having non-compliant BARs
> 
> 
>  arch/x86/pci/fixup.c |    7 +++++++
>  drivers/pci/probe.c  |   14 ++++++++++++++
>  drivers/pci/quirks.c |   14 ++++++++++++++
>  include/linux/pci.h  |    1 +
>  4 files changed, 36 insertions(+)

I applied the first two patches, with Andi's Tested-by, to
pci/resource for v4.6.

Per Jayachandran, the Broadcom patch turned out not to be necessary,
so I dropped that one.

Bjorn

  parent reply	other threads:[~2016-03-08 17:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 15:58 [PATCH v1 0/3] PCI: Avoid touching non-compliant BARs Bjorn Helgaas
2016-02-26 15:58 ` [PATCH v1 1/3] PCI: Disable IO/MEM decoding for devices with " Bjorn Helgaas
2016-02-26 15:58 ` [PATCH v1 2/3] x86/PCI: Mark Broadwell-EP Home Agent & PCU as having " Bjorn Helgaas
2016-02-26 15:59 ` [PATCH v1 3/3] PCI: Mark Broadcom Vulcan bridges " Bjorn Helgaas
2016-02-26 16:55 ` [PATCH v1 0/3] PCI: Avoid touching " Andi Kleen
2016-03-08 17:50 ` Bjorn Helgaas [this message]
2016-03-08 18:05   ` Andi Kleen
2016-03-08 18:16     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308175020.GD19869@localhost \
    --to=helgaas@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=jayachandran.chandrashekaran@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).