From: "Petr Štetiar" <ynezz@true.cz>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Petr Štetiar" <ynezz@true.cz>,
"Tim Harvey" <tharvey@gateworks.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Richard Zhu" <Richard.Zhu@freescale.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] Revert "PCI: imx6: Add support for active-low reset GPIO"
Date: Wed, 30 Mar 2016 15:00:02 +0200 [thread overview]
Message-ID: <20160330130002.GA13529@ibawizard.net> (raw)
In-Reply-To: <CAOMZO5Bh=JgVEMM-8JBX1cpk5Kgn2O2KBiOGdZT+QQfGUizBUg@mail.gmail.com>
Fabio Estevam <festevam@gmail.com> [2016-03-30 09:36:35]:
Hi Fabio,
> In order to make the Toradex board to work without breaking old dtb's is to
> introduce a property like 'phy-reset-active-high' and handle it in the
> driver.
do we really need to do this? With Krzysztof's patch it should work for both
cases correctly. If I understand gpiolib correctly, you don't need to
introduce reset-active-high, if you use gpiod_* functions, then the GPIO
polarity is handled correctly inside the gpiolib framework[1] and all you need
is to define pin's polarity correctly via gpio pin definition. Or am I missing
something?
Then we need to just fix the broken DTBs.
1. http://lxr.free-electrons.com/source/drivers/gpio/gpiolib.c#L1759
-- ynezz
next prev parent reply other threads:[~2016-03-30 13:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 21:45 [PATCH v2] Revert "PCI: imx6: Add support for active-low reset GPIO" Fabio Estevam
2016-03-29 13:43 ` Tim Harvey
2016-03-30 12:21 ` Petr Štetiar
2016-03-30 12:36 ` Fabio Estevam
2016-03-30 13:00 ` Petr Štetiar [this message]
2016-03-30 13:07 ` Fabio Estevam
2016-03-30 13:16 ` Petr Štetiar
2016-03-30 13:20 ` Lucas Stach
2016-03-30 13:25 ` Fabio Estevam
2016-03-31 5:07 ` Krzysztof Hałasa
2016-03-31 10:35 ` Lucas Stach
2016-04-01 7:26 ` Krzysztof Hałasa
2016-03-30 13:29 ` Lucas Stach
2016-04-05 19:10 ` Fabio Estevam
2016-04-05 21:31 ` Bjorn Helgaas
2016-04-05 22:07 ` Fabio Estevam
2016-04-18 2:41 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330130002.GA13529@ibawizard.net \
--to=ynezz@true.cz \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=khalasa@piap.pl \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).